FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

util: move deprecated utils to eol by marco-ippolito · Pull Request #52744 · nodejs/node · GitHub

/ node Public

util: move deprecated utils to eol - #52744

Closed
marco-ippolito wants to merge 16 commits into
nodejs:mainfrom
marco-ippolito:chore/deprecate-utils
ConversationCommits (16)ChecksFiles changed
Closed

util: move deprecated utils to eol#52744
marco-ippolito wants to merge 16 commits into
nodejs:mainfrom
marco-ippolito:chore/deprecate-utils

Conversation

marco-ippolito commented Apr 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

We are moving all the deprecated utils function to End Of Life

nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Apr 29, 2024
marco-ippolito force-pushed the chore/deprecate-utils branch from 27b2ed2 to 6a6fd9e Compare April 29, 2024 07:47
marco-ippolito added deprecations Issues and PRs related to deprecations. semver-major PRs that contain breaking changes and should be released in the next major version. wip Issues and PRs that are still a work in progress. labels Apr 29, 2024
targos added the needs-citgm PRs that need a CITGM CI run. label Apr 29, 2024
marco-ippolito force-pushed the chore/deprecate-utils branch 2 times, most recently from 3be425f to c70fe54 Compare April 29, 2024 09:07
marco-ippolito marked this pull request as ready for review April 29, 2024 09:40
marco-ippolito removed the wip Issues and PRs that are still a work in progress. label Apr 29, 2024
benjamingr approved these changes Apr 29, 2024
View reviewed changes

benjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We may want to mention a migration path or polyfill for when this lands in v23.

e.g. a codemod or some such to rewrite code using stuff like util.isNull

benjamingr commented Apr 29, 2024

Copy link
Copy Markdown
Member

Also cc @nodejs/tsc since this can break stuf

mcollina approved these changes Apr 29, 2024
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 29, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 29, 2024

nodejs-github-bot commented Apr 29, 2024 •
edited by marco-ippolito
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58793/ 🟢
CITGM: https://ci.nodejs.org/job/citgm-smoker/3423/

marco-ippolito commented Apr 29, 2024

Copy link
Copy Markdown
Member Author

We may want to mention a migration path or polyfill for when this lands in v23.

e.g. a codemod or some such to rewrite code using stuff like util.isNull

I'll add notable change then so we can mention the migration path in the changelog

marco-ippolito added the notable-change PRs with changes that should be highlighted in changelogs. label Apr 29, 2024

github-actions Bot commented Apr 29, 2024

Copy link
Copy Markdown
Contributor

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @marco-ippolito.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

targos commented Apr 29, 2024

Copy link
Copy Markdown
Member

It breaks a some high-impact packages in citgm.

marco-ippolito commented Apr 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

At first glance it seems the failures are all related to debug and form-data
Broken packages:

util._extend:

  • is-core-module v2.13.1 (from debug as dev-dependency)
  • minimist v1.2.8 (from debug as dev-dependency)
  • leveldown v6.1.1 (from debug as dev-dependency)
  • tape v5.7.5 (from debug as dev-dependency)

It seemed actually debug migrated away from _extend debug-js/debug@1351d2f and some libraries in the tree are still using a very old version

util.isArray:

  • multer v1.4.5-lts.1 (from form-data as dev-dependency)
  • fastify v4.26.2 (from form-data as dev-dependency)

marco-ippolito mentioned this pull request Apr 30, 2024
Closed
nodejs-github-bot pushed a commit that referenced this pull request May 6, 2024
util: move util.isPrimitive to eol
1d817dc 
PR-URL: #52744
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request May 6, 2024
util: move util.log to eol
982f6ad 
PR-URL: #52744
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS mentioned this pull request Oct 9, 2024
Merged
juniorUsca mentioned this pull request Oct 25, 2024
Closed
tharvik mentioned this pull request Oct 25, 2024
Merged
chenrui333 mentioned this pull request Nov 15, 2024
Merged
FGoessler mentioned this pull request Jan 3, 2025
Merged
anonrig mentioned this pull request Jan 28, 2025
Closed
9 tasks
aryamohanan mentioned this pull request Feb 20, 2025
Merged
nateevans mentioned this pull request Mar 24, 2025
Open
Renegade334 mentioned this pull request Apr 24, 2025
Closed
MattiSG mentioned this pull request Jul 27, 2025
Closed
AugustinMauroy mentioned this pull request Jul 28, 2025
Closed
9romise mentioned this pull request Nov 1, 2025
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
ShogunPanda ShogunPanda approved these changes
jasnell jasnell approved these changes
benjamingr benjamingr approved these changes
anonrig anonrig approved these changes
UlisesGascon UlisesGascon approved these changes
MoLow MoLow approved these changes
trivikr trivikr approved these changes
RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. deprecations Issues and PRs related to deprecations. needs-ci PRs that need a full CI run. needs-citgm PRs that need a CITGM CI run. notable-change PRs with changes that should be highlighted in changelogs. semver-major PRs that contain breaking changes and should be released in the next major version. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL