Commit 06a8243
test: improve test-event-emitter-modify-in-emit
* use let instead of var
* use assert.strictEqual instead of assert.equal
* swap assertions arguments to match the standard
PR-URL: #10600
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 75aa605 commit 06a8243
1 file changed
Lines changed: 9 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3,7 +3,7 @@ require('../common'); | |||
| 3 | 3 | const assert = require('assert'); | |
| 4 | 4 | const events = require('events'); | |
| 5 | 5 | ||
| 6 | - var callbacks_called = []; | ||
| 6 | + let callbacks_called = []; | ||
| 7 | 7 | ||
| 8 | 8 | const e = new events.EventEmitter(); | |
| 9 | 9 | ||
@@ -25,35 +25,35 @@ function callback3() { | |||
| 25 | 25 | } | |
| 26 | 26 | ||
| 27 | 27 | e.on('foo', callback1); | |
| 28 | - assert.equal(1, e.listeners('foo').length); | ||
| 28 | + assert.strictEqual(e.listeners('foo').length, 1); | ||
| 29 | 29 | ||
| 30 | 30 | e.emit('foo'); | |
| 31 | - assert.equal(2, e.listeners('foo').length); | ||
| 31 | + assert.strictEqual(e.listeners('foo').length, 2); | ||
| 32 | 32 | assert.deepStrictEqual(['callback1'], callbacks_called); | |
| 33 | 33 | ||
| 34 | 34 | e.emit('foo'); | |
| 35 | - assert.equal(0, e.listeners('foo').length); | ||
| 35 | + assert.strictEqual(e.listeners('foo').length, 0); | ||
| 36 | 36 | assert.deepStrictEqual(['callback1', 'callback2', 'callback3'], | |
| 37 | 37 | callbacks_called); | |
| 38 | 38 | ||
| 39 | 39 | e.emit('foo'); | |
| 40 | - assert.equal(0, e.listeners('foo').length); | ||
| 40 | + assert.strictEqual(e.listeners('foo').length, 0); | ||
| 41 | 41 | assert.deepStrictEqual(['callback1', 'callback2', 'callback3'], | |
| 42 | 42 | callbacks_called); | |
| 43 | 43 | ||
| 44 | 44 | e.on('foo', callback1); | |
| 45 | 45 | e.on('foo', callback2); | |
| 46 | - assert.equal(2, e.listeners('foo').length); | ||
| 46 | + assert.strictEqual(e.listeners('foo').length, 2); | ||
| 47 | 47 | e.removeAllListeners('foo'); | |
| 48 | - assert.equal(0, e.listeners('foo').length); | ||
| 48 | + assert.strictEqual(e.listeners('foo').length, 0); | ||
| 49 | 49 | ||
| 50 | 50 | // Verify that removing callbacks while in emit allows emits to propagate to | |
| 51 | 51 | // all listeners | |
| 52 | 52 | callbacks_called = []; | |
| 53 | 53 | ||
| 54 | 54 | e.on('foo', callback2); | |
| 55 | 55 | e.on('foo', callback3); | |
| 56 | - assert.equal(2, e.listeners('foo').length); | ||
| 56 | + assert.strictEqual(2, e.listeners('foo').length); | ||
| 57 | 57 | e.emit('foo'); | |
| 58 | 58 | assert.deepStrictEqual(['callback2', 'callback3'], callbacks_called); | |
| 59 | - assert.equal(0, e.listeners('foo').length); | ||
| 59 | + assert.strictEqual(0, e.listeners('foo').length); | ||
0 commit comments