FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: improve test-event-emitter-modify-in-emit by edsadr · Pull Request #10600 · nodejs/node · GitHub

/ node Public

test: improve test-event-emitter-modify-in-emit - #10600

Closed
edsadr wants to merge 1 commit into
nodejs:masterfrom
edsadr:event-emitter-modify
ConversationCommits (1)ChecksFiles changed
Closed

test: improve test-event-emitter-modify-in-emit#10600
edsadr wants to merge 1 commit into
nodejs:masterfrom
edsadr:event-emitter-modify

Conversation

edsadr commented Jan 4, 2017

Copy link
Copy Markdown
Contributor
  • use let instead of var
  • use assert.strictEqual instead of assert.equal
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

nodejs-github-bot added test Issues and PRs related to the tests. lts-watch-v6.x labels Jan 4, 2017
mscdex added the events Issues and PRs related to the events subsystem / EventEmitter. label Jan 4, 2017
lpinca reviewed Jan 6, 2017
View reviewed changes
Comment thread test/parallel/test-event-emitter-modify-in-emit.js Outdated

lpinca Jan 6, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nit: can you please swap the arguments?

test: improve test-event-emitter-modify-in-emit
35ef607 
* use let instead of var
* use assert.strictEqual instead of assert.equal
* swap assertions arguments to match the standard
edsadr force-pushed the event-emitter-modify branch from 7017afa to 35ef607 Compare January 6, 2017 17:52

edsadr commented Jan 6, 2017

Copy link
Copy Markdown
Contributor Author

@lpinca , did the nit

lpinca commented Jan 6, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/5731/

lpinca commented Jan 6, 2017

Copy link
Copy Markdown
Member

Landed in 75ebd19.

lpinca closed this Jan 6, 2017
lpinca pushed a commit that referenced this pull request Jan 6, 2017
test: improve test-event-emitter-modify-in-emit
75ebd19 
* use let instead of var
* use assert.strictEqual instead of assert.equal
* swap assertions arguments to match the standard

PR-URL: #10600
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
test: improve test-event-emitter-modify-in-emit
17c86ac 
* use let instead of var
* use assert.strictEqual instead of assert.equal
* swap assertions arguments to match the standard

PR-URL: nodejs#10600
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 19, 2017
test: improve test-event-emitter-modify-in-emit
7032f81 
* use let instead of var
* use assert.strictEqual instead of assert.equal
* swap assertions arguments to match the standard

PR-URL: nodejs#10600
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 24, 2017
test: improve test-event-emitter-modify-in-emit
e134247 
* use let instead of var
* use assert.strictEqual instead of assert.equal
* swap assertions arguments to match the standard

PR-URL: nodejs#10600
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas mentioned this pull request Jan 25, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
test: improve test-event-emitter-modify-in-emit
06a8243 
* use let instead of var
* use assert.strictEqual instead of assert.equal
* swap assertions arguments to match the standard

PR-URL: nodejs#10600
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas mentioned this pull request Jan 29, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
test: improve test-event-emitter-modify-in-emit
9a99608 
* use let instead of var
* use assert.strictEqual instead of assert.equal
* swap assertions arguments to match the standard

PR-URL: #10600
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
test: improve test-event-emitter-modify-in-emit
17a63e1 
* use let instead of var
* use assert.strictEqual instead of assert.equal
* swap assertions arguments to match the standard

PR-URL: #10600
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Mar 9, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

events Issues and PRs related to the events subsystem / EventEmitter. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL