Commit 071836a
repl: name anonymous functions
the changes are related to #8913
regarding the naming of just the inline anonymous
functions that are not assigned to a variable
PR-URL: #9356
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>1 parent d09eb9c commit 071836a
1 file changed
Lines changed: 7 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -354,7 +354,7 @@ function REPLServer(prompt, | |||
| 354 | 354 | ||
| 355 | 355 | self.eval = self._domain.bind(eval_); | |
| 356 | 356 | ||
| 357 | - self._domain.on('error', function(e) { | ||
| 357 | + self._domain.on('error', function debugDomainError(e) { | ||
| 358 | 358 | debug('domain error'); | |
| 359 | 359 | const top = replMap.get(self); | |
| 360 | 360 | internalUtil.decorateErrorStack(e); | |
@@ -436,13 +436,13 @@ function REPLServer(prompt, | |||
| 436 | 436 | }; | |
| 437 | 437 | } | |
| 438 | 438 | ||
| 439 | - self.on('close', function() { | ||
| 439 | + self.on('close', function emitExit() { | ||
| 440 | 440 | self.emit('exit'); | |
| 441 | 441 | }); | |
| 442 | 442 | ||
| 443 | 443 | var sawSIGINT = false; | |
| 444 | 444 | var sawCtrlD = false; | |
| 445 | - self.on('SIGINT', function() { | ||
| 445 | + self.on('SIGINT', function onSigInt() { | ||
| 446 | 446 | var empty = self.line.length === 0; | |
| 447 | 447 | self.clearLine(); | |
| 448 | 448 | self.turnOffEditorMode(); | |
@@ -465,7 +465,7 @@ function REPLServer(prompt, | |||
| 465 | 465 | self.displayPrompt(); | |
| 466 | 466 | }); | |
| 467 | 467 | ||
| 468 | - self.on('line', function(cmd) { | ||
| 468 | + self.on('line', function onLine(cmd) { | ||
| 469 | 469 | debug('line %j', cmd); | |
| 470 | 470 | sawSIGINT = false; | |
| 471 | 471 | ||
@@ -586,7 +586,7 @@ function REPLServer(prompt, | |||
| 586 | 586 | } | |
| 587 | 587 | }); | |
| 588 | 588 | ||
| 589 | - self.on('SIGCONT', function() { | ||
| 589 | + self.on('SIGCONT', function onSigCont() { | ||
| 590 | 590 | if (self.editorMode) { | |
| 591 | 591 | self.outputStream.write(`${self._initialPrompt}.editor\n`); | |
| 592 | 592 | self.outputStream.write( | |
@@ -951,7 +951,7 @@ function complete(line, callback) { | |||
| 951 | 951 | addStandardGlobals(completionGroups, filter); | |
| 952 | 952 | completionGroupsLoaded(); | |
| 953 | 953 | } else { | |
| 954 | - this.eval('.scope', this.context, 'repl', function(err, globals) { | ||
| 954 | + this.eval('.scope', this.context, 'repl', function ev(err, globals) { | ||
| 955 | 955 | if (err || !Array.isArray(globals)) { | |
| 956 | 956 | addStandardGlobals(completionGroups, filter); | |
| 957 | 957 | } else if (Array.isArray(globals[0])) { | |
@@ -968,7 +968,7 @@ function complete(line, callback) { | |||
| 968 | 968 | } | |
| 969 | 969 | } else { | |
| 970 | 970 | const evalExpr = `try { ${expr} } catch (e) {}`; | |
| 971 | - this.eval(evalExpr, this.context, 'repl', function(e, obj) { | ||
| 971 | + this.eval(evalExpr, this.context, 'repl', function doEval(e, obj) { | ||
| 972 | 972 | // if (e) console.log(e); | |
| 973 | 973 | ||
| 974 | 974 | if (obj != null) { | |
0 commit comments