FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

name repl anonymous functions by pvsousalima · Pull Request #9356 · nodejs/node · GitHub

/ node Public

name repl anonymous functions - #9356

Closed
pvsousalima wants to merge 2 commits into
nodejs:masterfrom
pvsousalima:name_repl_anonymous
ConversationCommits (2)ChecksFiles changed
Closed

name repl anonymous functions#9356
pvsousalima wants to merge 2 commits into
nodejs:masterfrom
pvsousalima:name_repl_anonymous

Conversation

pvsousalima commented Oct 29, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

repl

Description of change

repl: name anonymous functions in repl module

name anonymous functions in repl module
the changes are related to Ref: #8913
regarding the naming of just the inline anonymous
functions that are not assigned to a variable

repl: name anonymous functions in repl module
ffcb038 
name anonymous functions in repl module
the changes are related to Ref: #8913
regarding the naming of just the inline anonymous
functions that are not assigned to a variable
repl: name anonymous functions in repl module
54dee96 
removing long function names to match the 80
character limitation
nodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label Oct 29, 2016
pvsousalima changed the title Name repl anonymous name repl anonymous Oct 29, 2016
pvsousalima changed the title name repl anonymous name repl anonymous functions Oct 29, 2016

Trott commented Oct 29, 2016

Copy link
Copy Markdown
Member

LGTM if CI is ✅

jasnell approved these changes Oct 30, 2016
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

silverwind commented Nov 1, 2016

Copy link
Copy Markdown
Contributor

Thanks! Landed in e658f5b.

silverwind closed this Nov 1, 2016
silverwind pushed a commit that referenced this pull request Nov 1, 2016
repl: name anonymous functions
e658f5b 
the changes are related to #8913
regarding the naming of just the inline anonymous
functions that are not assigned to a variable

PR-URL: #9356
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
repl: name anonymous functions
071836a 
the changes are related to #8913
regarding the naming of just the inline anonymous
functions that are not assigned to a variable

PR-URL: #9356
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
evanlucas mentioned this pull request Nov 3, 2016
Merged
MylesBorins added the baking-for-lts PRs that need to wait before landing in a LTS release. label May 8, 2017
MylesBorins added dont-land-on-v6.x and removed baking-for-lts PRs that need to wait before landing in a LTS release. lts-watch-v6.x labels Nov 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
+1 more reviewer
silverwind silverwind approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

repl Issues and PRs related to the REPL subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL