test: improve known_issues/test-vm-timeout-escape-queuemicrotask · nodejs/node@0b1a9aa · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 0b1a9aa

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

addaleax

committed

test: improve known_issues/test-vm-timeout-escape-queuemicrotask

Improve known_issues/test-vm-timeout-escape-queuemicrotask to mitigate CI failures on ubuntu1604-arm64. Failures are due to a race condition. Use `common.platformTimeout()` to help, adjust timeout to make sure `queueMicrotasks()` has a chance to run, and improve error message. PR-URL: #25503 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Coe <bencoe@gmail.com>

1 parent 736349c commit 0b1a9aa
Copy full SHA for 0b1a9aa

1 file changed

+7-4Lines changed: 7 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/known_issues
  • test-vm-timeout-escape-queuemicrotask.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/known_issues/test-vm-timeout-escape-queuemicrotask.js‎

Copy file name to clipboardExpand all lines: test/known_issues/test-vm-timeout-escape-queuemicrotask.js

+7-4Lines changed: 7 additions & 4 deletions

Original file line number	Diff line number	Diff line change
@@ -12,14 +12,17 @@ const NS_PER_MS = 1000000n;
12	12
13	13	const hrtime = process.hrtime.bigint;
14	14
	15	+ const loopDuration = common.platformTimeout(100n);
	16	+ const timeout = common.platformTimeout(10);
	17	+
15	18	function loop() {
16	19	const start = hrtime();
17	20	while (1) {
18	21	const current = hrtime();
19	22	const span = (current - start) / NS_PER_MS;
20		- if (span >= 100n) {
	23	+ if (span >= loopDuration) {
21	24	throw new Error(
22		- `escaped timeout at ${span} milliseconds!`);
	25	+ `escaped ${timeout}ms timeout at ${span}ms`);
23	26	}
24	27	}
25	28	}
@@ -32,9 +35,9 @@ assert.throws(() => {
32	35	queueMicrotask,
33	36	loop
34	37	},
35		- { timeout: common.platformTimeout(5) }
	38	+ { timeout }
36	39	);
37	40	}, {
38	41	code: 'ERR_SCRIPT_EXECUTION_TIMEOUT',
39		- message: 'Script execution timed out after 5ms'
	42	+ message: `Script execution timed out after ${timeout}ms`
40	43	});

0 commit comments

Comments

0 (0)