FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: improve known_issues/test-vm-timeout-escape-queuemicrotask by Trott · Pull Request #25503 · nodejs/node · GitHub

/ node Public

test: improve known_issues/test-vm-timeout-escape-queuemicrotask - #25503

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:more-microtask
ConversationCommits (1)ChecksFiles changed
Closed

test: improve known_issues/test-vm-timeout-escape-queuemicrotask#25503
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:more-microtask

Conversation

Trott commented Jan 14, 2019

Copy link
Copy Markdown
Member

Improve known_issues/test-vm-timeout-escape-queuemicrotask to mitigate
CI failures on ubuntu1604-arm64. Failures are due to a race condition.
Use common.platformTimeout() to help, adjust timeout to make sure
queueMicrotasks() has a chance to run, and improve error message.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

test: improve known_issues/test-vm-timeout-escape-queuemicrotask
ea51df3 
Improve known_issues/test-vm-timeout-escape-queuemicrotask to mitigate
CI failures on ubuntu1604-arm64. Failures are due to a race condition.
Use `common.platformTimeout()` to help, adjust timeout to make sure
`queueMicrotasks()` has a chance to run, and improve error message.

nodejs-github-bot commented Jan 14, 2019

Copy link
Copy Markdown
Collaborator

@Trott sadly an error occured when I tried to trigger a build :(

nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 14, 2019

Trott commented Jan 14, 2019 •
edited by refack
Loading

Copy link
Copy Markdown
Member Author

CI against master hopefully showing this flaky on ubuntu1604-arm64: https://ci.nodejs.org/job/node-stress-single-test/2132/ - (0/1000 OK)

CI against this PR hopefully showing it reliable on ubuntu1604-arm64: https://ci.nodejs.org/job/node-stress-single-test/2133/

CI (scheduled): https://ci.nodejs.org/job/node-test-pull-request/20126/

refack commented Jan 14, 2019

Copy link
Copy Markdown
Contributor

Seems to be overwhelmingly better. As in pre-PR 0/1000 iterations passed, and post-PR ATM all iterations pass (151/151). Just to make sure, both tests run on test-packetnet-ubuntu1604-arm64-2. In this case I think it makes sense to fast track. Please 👍 if you concur.

refack added known limitation Issues that are identified as known limitations. flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. labels Jan 14, 2019
Trott mentioned this pull request Jan 14, 2019
Closed
4 tasks
bcoe approved these changes Jan 15, 2019
View reviewed changes

bcoe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🎉 thanks, have been wrestling with this trying to get a few branches to pass.

Trott commented Jan 15, 2019

Copy link
Copy Markdown
Member Author

Unrelated failure in another test on Windows. Re-running just Windows (because still waiting for AIX which hasn't even started yet): https://ci.nodejs.org/job/node-test-commit-windows-fanned/23965/

Trott commented Jan 15, 2019

Copy link
Copy Markdown
Member Author

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/20132/

Trott commented Jan 15, 2019 •
edited by refack
Loading

Copy link
Copy Markdown
Member Author

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/20133/

Three failures in a row on Windows for parallel/test-trace-events-fs-sync. Starting to worry about that one....

Trott commented Jan 15, 2019

Copy link
Copy Markdown
Member Author

Did a full CI re-run and this time Windows passed: https://ci.nodejs.org/job/node-test-commit/25058/

Re-running FreeBSD (only failure, unrelated): https://ci.nodejs.org/job/node-test-commit-freebsd/23400/

Trott commented Jan 15, 2019

Copy link
Copy Markdown
Member Author

FreeBSD re-run was green. Landing...

Landed in 27f6d04

Trott closed this Jan 15, 2019
Trott added a commit to Trott/io.js that referenced this pull request Jan 15, 2019
test: improve known_issues/test-vm-timeout-escape-queuemicrotask
27f6d04 
Improve known_issues/test-vm-timeout-escape-queuemicrotask to mitigate
CI failures on ubuntu1604-arm64. Failures are due to a race condition.
Use `common.platformTimeout()` to help, adjust timeout to make sure
`queueMicrotasks()` has a chance to run, and improve error message.

PR-URL: nodejs#25503
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Coe <bencoe@gmail.com>
addaleax pushed a commit that referenced this pull request Jan 15, 2019
test: improve known_issues/test-vm-timeout-escape-queuemicrotask
0b1a9aa 
Improve known_issues/test-vm-timeout-escape-queuemicrotask to mitigate
CI failures on ubuntu1604-arm64. Failures are due to a race condition.
Use `common.platformTimeout()` to help, adjust timeout to make sure
`queueMicrotasks()` has a chance to run, and improve error message.

PR-URL: #25503
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Coe <bencoe@gmail.com>
This was referenced Jan 16, 2019
Closed
Closed
gireeshpunathil mentioned this pull request Jan 16, 2019
Closed
BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
test: improve known_issues/test-vm-timeout-escape-queuemicrotask
5be6ce0 
Improve known_issues/test-vm-timeout-escape-queuemicrotask to mitigate
CI failures on ubuntu1604-arm64. Failures are due to a race condition.
Use `common.platformTimeout()` to help, adjust timeout to make sure
`queueMicrotasks()` has a chance to run, and improve error message.

PR-URL: nodejs#25503
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Coe <bencoe@gmail.com>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 17, 2019
test: improve known_issues/test-vm-timeout-escape-queuemicrotask
d7bc03e 
Improve known_issues/test-vm-timeout-escape-queuemicrotask to mitigate
CI failures on ubuntu1604-arm64. Failures are due to a race condition.
Use `common.platformTimeout()` to help, adjust timeout to make sure
`queueMicrotasks()` has a chance to run, and improve error message.

PR-URL: nodejs#25503
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Coe <bencoe@gmail.com>
MylesBorins mentioned this pull request Jan 24, 2019
Merged
Trott deleted the more-microtask branch January 13, 2022 22:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
+2 more reviewers
refack refack approved these changes
bcoe bcoe approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. known limitation Issues that are identified as known limitations. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL