test_runner: expose lcov reporter as newable function · nodejs/node@0db38f0 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 750
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 0db38f0

Browse filesBrowse the repository at this point in the historyBrowse files

atlowChemi

authored

test_runner: expose lcov reporter as newable function

This commit exposes the lcov reporter as a newable function, so that it can be used in the same way as the other reporters. This will allow passing in the options to the reporter as well. This breaks the current behavior of the lcov reporter, which exposes an instance of the reporter. Fixes: #52385 Ref: #49184 PR-URL: #52403 Refs: #49184 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

1 parent f8e325e commit 0db38f0
Copy full SHA for 0db38f0

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/test
  • reporters.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/test/reporters.js‎

Copy file name to clipboardExpand all lines: lib/test/reporters.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -50,7 +50,7 @@ ObjectDefineProperties(module.exports, {
50	50	__proto__: null,
51	51	configurable: true,
52	52	enumerable: true,
53		- get() {
	53	+ value: function value() {
54	54	lcov ??= require('internal/test_runner/reporter/lcov');
55	55	return ReflectConstruct(lcov, arguments);
56	56	},

0 commit comments

Comments

0 (0)