test_runner: expose spec reporter as newable function - #49184
Merged
nodejs-github-bot merged 1 commit intoAug 17, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
atlowChemi
force-pushed
the
spec-reporter-as-function
branch
2 times, most recently
from
7a2f61e to
f217312
Compare
August 15, 2023 18:20
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
benjamingr
approved these changes
Aug 15, 2023
MoLow
approved these changes
Aug 15, 2023
Copy link
Copy Markdown
Member
|
@atlowChemi can you amend the commit message changing from expose test_runner as newable function to expose spec reporter as newable function |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Oh, of course. That was what I meant, oopsy 🙂 |
Sorry, something went wrong.
atlowChemi
force-pushed
the
spec-reporter-as-function
branch
from
f217312 to
193c63a
Compare
August 16, 2023 05:05
Copy link
Copy Markdown
Member
Author
|
@MoLow fixed commit message, care to re-approve latest commit? 🙂 |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
MoLow
approved these changes
Aug 16, 2023
UlisesGascon
pushed a commit
that referenced
this pull request
Sep 10, 2023
Merged
targos
pushed a commit
that referenced
this pull request
Nov 27, 2023
atlowChemi
added a commit
to atlowChemi/node
that referenced
this pull request
Apr 14, 2024
This commit exposes the lcov reporter as a newable function, so that it can be used in the same way as the other reporters. This will allow passing in the options to the reporter as well. This breaks the current behavior of the lcov reporter, which exposes an instance of the reporter. Fixes: nodejs#52385 Ref: nodejs#49184
nodejs-github-bot
pushed a commit
that referenced
this pull request
Apr 15, 2024
This commit exposes the lcov reporter as a newable function, so that it can be used in the same way as the other reporters. This will allow passing in the options to the reporter as well. This breaks the current behavior of the lcov reporter, which exposes an instance of the reporter. Fixes: #52385 Ref: #49184 PR-URL: #52403 Refs: #49184 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Fixes: nodejs/node#48112 Ref: nodejs/node#48208 PR-URL: nodejs/node#49184 Refs: nodejs/node#48208 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Fixes: nodejs/node#48112 Ref: nodejs/node#48208 PR-URL: nodejs/node#49184 Refs: nodejs/node#48208 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95
pushed a commit
that referenced
this pull request
Apr 30, 2024
This commit exposes the lcov reporter as a newable function, so that it can be used in the same way as the other reporters. This will allow passing in the options to the reporter as well. This breaks the current behavior of the lcov reporter, which exposes an instance of the reporter. Fixes: #52385 Ref: #49184 PR-URL: #52403 Refs: #49184 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #48112
Ref: #48208