test_runner: handled change for exposing 'spec' reporter - #48202
Conversation
Other reporters (dot, tap) by signature are a function while 'spec' reporter is a ES6 class. This behaviour of api spec is causing difference in semantics while consumption since it has not been addressed anywhere in the document (it has to be instantiated). Instead of making changes in the signature of spec.js, i have proposed changes where the 'spec' reporter gets exposed in reporter.js Fixes: nodejs#48112 Refs: https://github.com/nodejs/node/blob/main/lib/internal/test_runner/reporter/spec.js Refs: (@line-no:143) https://github.com/nodejs/node/blob/main/lib/internal/test_runner/utils.js
|
Review requested:
|
Sorry, something went wrong.
|
I do not understand why is the test failing @line-no:79 test-runner-run.mjs. |
Sorry, something went wrong.
|
you should debug locally with ./node test/parallel/test-runner-run.mjs |
Sorry, something went wrong.
not ok 9 - should be piped with spec
---
duration_ms: 1767.493155
failureType: 'cancelledByParent'
error: 'Promise resolution is still pending but the event loop has already resolved'
code: 'ERR_TEST_FAILURE'
stack: |-
process.emit (node:events:523:35)
...
|
Sorry, something went wrong.
| value: spec ?? function SpecReporter() { | ||
| return ReflectConstruct(require('internal/test_runner/reporter/spec'), arguments); |
There was a problem hiding this comment.
| value: spec ?? function SpecReporter() { | |
| return ReflectConstruct(require('internal/test_runner/reporter/spec'), arguments); | |
| value: function SpecReporter() { | |
| spec ??= require('internal/test_runner/reporter/spec'); | |
| return ReflectConstruct(spec, arguments, new.target); |
(not sure about the new.target)
Sorry, something went wrong.
There was a problem hiding this comment.
Let me run full test this time on my local and check.
Sorry, something went wrong.
There was a problem hiding this comment.
@atlowChemi I have tried all versions of returning instance of a class (imported with require), either with new keyword or with Reflect.construct, and both are not working.
I am not able to identify the Root cause.
Sorry, something went wrong.
|
@Sumi0 are you still planning to work on this, or should it be closed? |
Sorry, something went wrong.
|
This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open. |
Sorry, something went wrong.
Fixes: Issue#48112
Other reporters (dot, tap) by signature are a function while 'spec'
reporter is a ES6 class.
This behaviour of api spec is causing difference in semantics while
consumption since it has not been addressed anywhere in the document
(it has to be instantiated).
Instead of making changes in the signature of spec.js, i have proposed
changes where the 'spec' reporter gets exposed in reporter.js
Refs: reporter/spec.js
Refs: (@line-no:143) test_runner/utils.js