Commit 0f3cf7e
Revert "build: remove precompiled header and debug information for host builds"
This reverts commit 818284b.
Reverted commit is a no longer needed patch for ARM64 cross-compiling.
It was increasing cross-compile time drastically (~3 times longer).
PR-URL: #45432
Refs: #42538
Refs: #42375
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>1 parent 8d96e2c commit 0f3cf7e
2 files changed
Lines changed: 6 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -283,11 +283,7 @@ | |||
| 283 | 283 | '-std:c++17' | |
| 284 | 284 | ], | |
| 285 | 285 | 'BufferSecurityCheck': 'true', | |
| 286 | - 'target_conditions': [ | ||
| 287 | - ['_toolset=="target"', { | ||
| 288 | - 'DebugInformationFormat': 1 # /Z7 embed info in .obj files | ||
| 289 | - }], | ||
| 290 | - ], | ||
| 286 | + 'DebugInformationFormat': 1, # /Z7 embed info in .obj files | ||
| 291 | 287 | 'ExceptionHandling': 0, # /EHsc | |
| 292 | 288 | 'MultiProcessorCompilation': 'true', | |
| 293 | 289 | 'StringPooling': 'true', # pool string literals | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -325,7 +325,7 @@ | |||
| 325 | 325 | '<(V8_ROOT)/src/builtins/builtins-intl-gen.cc', | |
| 326 | 326 | ], | |
| 327 | 327 | }], | |
| 328 | - ['OS=="win" and _toolset=="target"', { | ||
| 328 | + ['OS=="win"', { | ||
| 329 | 329 | 'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h', | |
| 330 | 330 | 'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc', | |
| 331 | 331 | 'sources': [ | |
@@ -683,7 +683,7 @@ | |||
| 683 | 683 | ], | |
| 684 | 684 | 'sources': ['<@(v8_compiler_sources)'], | |
| 685 | 685 | 'conditions': [ | |
| 686 | - ['OS=="win" and _toolset=="target"', { | ||
| 686 | + ['OS=="win"', { | ||
| 687 | 687 | 'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h', | |
| 688 | 688 | 'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc', | |
| 689 | 689 | 'sources': [ | |
@@ -708,7 +708,7 @@ | |||
| 708 | 708 | ], | |
| 709 | 709 | 'sources': ['<@(v8_compiler_sources)'], | |
| 710 | 710 | 'conditions': [ | |
| 711 | - ['OS=="win" and _toolset=="target"', { | ||
| 711 | + ['OS=="win"', { | ||
| 712 | 712 | 'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h', | |
| 713 | 713 | 'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc', | |
| 714 | 714 | 'sources': [ | |
@@ -908,15 +908,13 @@ | |||
| 908 | 908 | '<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "\\"v8_base_without_compiler.*?v8_current_cpu == \\"loong64\\".*?sources \\+= ")', | |
| 909 | 909 | ], | |
| 910 | 910 | }], | |
| 911 | - ['OS=="win" and _toolset=="target"', { | ||
| 911 | + ['OS=="win"', { | ||
| 912 | 912 | 'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h', | |
| 913 | 913 | 'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc', | |
| 914 | 914 | 'sources': [ | |
| 915 | 915 | '<(_msvs_precompiled_header)', | |
| 916 | 916 | '<(_msvs_precompiled_source)', | |
| 917 | - ] | ||
| 918 | - }], | ||
| 919 | - ['OS=="win"', { | ||
| 917 | + ], | ||
| 920 | 918 | # This will prevent V8's .cc files conflicting with the inspector's | |
| 921 | 919 | # .cpp files in the same shard. | |
| 922 | 920 | 'msvs_settings': { | |
0 commit comments