build: remove precompiled header and debug information for host builds - #42538
Merged
nodejs-github-bot merged 1 commit intoApr 5, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
jasnell
approved these changes
Apr 3, 2022
targos
approved these changes
Apr 4, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@targos I am not sure if the CI failures are related to this patch. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Probably unrelated. I restarted CI. |
Sorry, something went wrong.
Merged
xtx1130
pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
PR-URL: nodejs#42538 Refs: nodejs#42375 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#42538 Refs: nodejs/node#42375 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 18, 2022
…st builds" This reverts commit 818284b. Reverted commit is a no longer needed patch for ARM64 cross-compiling. It was increasing cross-compile time drastically (~3 times longer). PR-URL: #45432 Refs: #42538 Refs: #42375 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Stewart X Addison <sxa@redhat.com>
ruyadorno
pushed a commit
that referenced
this pull request
Nov 21, 2022
…st builds" This reverts commit 818284b. Reverted commit is a no longer needed patch for ARM64 cross-compiling. It was increasing cross-compile time drastically (~3 times longer). PR-URL: #45432 Refs: #42538 Refs: #42375 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Stewart X Addison <sxa@redhat.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
…st builds" This reverts commit 818284b. Reverted commit is a no longer needed patch for ARM64 cross-compiling. It was increasing cross-compile time drastically (~3 times longer). PR-URL: #45432 Refs: #42538 Refs: #42375 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Stewart X Addison <sxa@redhat.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
…st builds" This reverts commit 818284b. Reverted commit is a no longer needed patch for ARM64 cross-compiling. It was increasing cross-compile time drastically (~3 times longer). PR-URL: #45432 Refs: #42538 Refs: #42375 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Stewart X Addison <sxa@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required to fix cross-compilation of windows/arm64 builds.
Precompiled header includes arm64 register configurations which are included for host builds and conflicts with x64 register. So they have to be removed from host builds.
Debug information is also disabled for host builds to avoid creating large libraries linker cannot handle.
Refs: #42375