Commit 1015b22
build: compile bundled ada conditionally
The --shared-ada flag was introduced in #52924, but the implementation
was incomplete.
Resolves #52914
PR-URL: #55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>1 parent 5bdfde8 commit 1015b22
2 files changed
Lines changed: 4 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -859,7 +859,6 @@ | |||
| 859 | 859 | 'deps/histogram/histogram.gyp:histogram', | |
| 860 | 860 | 'deps/simdjson/simdjson.gyp:simdjson', | |
| 861 | 861 | 'deps/simdutf/simdutf.gyp:simdutf', | |
| 862 | - 'deps/ada/ada.gyp:ada', | ||
| 863 | 862 | 'deps/nbytes/nbytes.gyp:nbytes', | |
| 864 | 863 | 'node_js2c#host', | |
| 865 | 864 | ], | |
@@ -1135,7 +1134,6 @@ | |||
| 1135 | 1134 | 'deps/googletest/googletest.gyp:gtest_prod', | |
| 1136 | 1135 | 'deps/histogram/histogram.gyp:histogram', | |
| 1137 | 1136 | 'deps/uvwasi/uvwasi.gyp:uvwasi', | |
| 1138 | - 'deps/ada/ada.gyp:ada', | ||
| 1139 | 1137 | 'deps/nbytes/nbytes.gyp:nbytes', | |
| 1140 | 1138 | ], | |
| 1141 | 1139 | 'includes': [ | |
@@ -1184,7 +1182,6 @@ | |||
| 1184 | 1182 | 'deps/histogram/histogram.gyp:histogram', | |
| 1185 | 1183 | 'deps/simdjson/simdjson.gyp:simdjson', | |
| 1186 | 1184 | 'deps/simdutf/simdutf.gyp:simdutf', | |
| 1187 | - 'deps/ada/ada.gyp:ada', | ||
| 1188 | 1185 | 'deps/nbytes/nbytes.gyp:nbytes', | |
| 1189 | 1186 | ], | |
| 1190 | 1187 | ||
@@ -1262,7 +1259,6 @@ | |||
| 1262 | 1259 | 'dependencies': [ | |
| 1263 | 1260 | '<(node_lib_target_name)', | |
| 1264 | 1261 | 'deps/histogram/histogram.gyp:histogram', | |
| 1265 | - 'deps/ada/ada.gyp:ada', | ||
| 1266 | 1262 | 'deps/nbytes/nbytes.gyp:nbytes', | |
| 1267 | 1263 | ], | |
| 1268 | 1264 | ||
@@ -1376,7 +1372,6 @@ | |||
| 1376 | 1372 | 'dependencies': [ | |
| 1377 | 1373 | '<(node_lib_target_name)', | |
| 1378 | 1374 | 'deps/histogram/histogram.gyp:histogram', | |
| 1379 | - 'deps/ada/ada.gyp:ada', | ||
| 1380 | 1375 | 'deps/nbytes/nbytes.gyp:nbytes', | |
| 1381 | 1376 | 'deps/simdjson/simdjson.gyp:simdjson', | |
| 1382 | 1377 | 'deps/simdutf/simdutf.gyp:simdutf', | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -212,6 +212,10 @@ | |||
| 212 | 212 | 'dependencies': [ 'deps/nghttp2/nghttp2.gyp:nghttp2' ], | |
| 213 | 213 | }], | |
| 214 | 214 | ||
| 215 | + [ 'node_shared_ada=="false"', { | ||
| 216 | + 'dependencies': [ 'deps/ada/ada.gyp:ada' ], | ||
| 217 | + }], | ||
| 218 | + | ||
| 215 | 219 | [ 'node_shared_brotli=="false"', { | |
| 216 | 220 | 'dependencies': [ 'deps/brotli/brotli.gyp:brotli' ], | |
| 217 | 221 | }], | |
0 commit comments