deps: enable unbundling of simdjson, simdutf, ada - #52924
Merged
nodejs-github-bot merged 4 commits intoMay 11, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
anonrig
approved these changes
May 9, 2024
richardlau
reviewed
May 9, 2024
richardlau
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I'm assuming the default libnames are the same as the * part of the --shared-*-libname pattern. Please amend accordingly if not. They're almost certainly not likely to be z 🙂.
Sorry, something went wrong.
Comment thread
configure.py
Outdated
Comment thread
configure.py
Outdated
Comment thread
configure.py
Outdated
Copy link
Copy Markdown
|
Is it possible to add ngtcp2 to this pr, or should that be done in another pr? |
Sorry, something went wrong.
Co-authored-by: Richard Lau <rlau@redhat.com>
Co-authored-by: Richard Lau <rlau@redhat.com>
Co-authored-by: Richard Lau <rlau@redhat.com>
Copy link
Copy Markdown
Member
Author
|
@williamh My reading of the code is that ngtcp2 can be made unbundled right now. But gentoo does not choose to do so. I think @jasnell did add this feature already. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Ok, thanks for this info, I'll take a look at my side again. |
Sorry, something went wrong.
richardlau
approved these changes
May 9, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
May 10, 2024
benjamingr
approved these changes
May 10, 2024
targos
pushed a commit
that referenced
this pull request
May 12, 2024
PR-URL: #52924 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 17, 2024
PR-URL: #52924 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
soophoo
pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#52924 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
jirutka
added a commit
to jirutka/node
that referenced
this pull request
Nov 16, 2024
The --shared-ada flag was introduced in nodejs#52924, but the implementation was incomplete. Resolves nodejs#52914
jirutka
added a commit
to jirutka/node
that referenced
this pull request
Nov 16, 2024
The --shared-simdjson flag was introduced in nodejs#52924, but the implementation was incomplete. Resolves nodejs#52914
jirutka
added a commit
to jirutka/node
that referenced
this pull request
Nov 16, 2024
The --shared-simdutf flag was introduced in nodejs#52924, but the implementation was incomplete. Resolves nodejs#52914
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building Node.js, it is possible to replace most dependencies by locally provided ones. However, it does not apply for at least three dependencies: simdjson, simdutf, ada. This PR seeks to enable this possibility.
Fixes #52914