Commit 132f6cb
doc: update onboarding task
Make starting Jenkins CI optional.
PR-URL: #40570
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 08e7a2f commit 132f6cb
1 file changed
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -215,7 +215,9 @@ needs to be pointed out separately during the onboarding. | |||
| 215 | 215 | labels. The `fast-track` label should cause the Node.js GitHub bot to post a | |
| 216 | 216 | comment in the pull request asking collaborators to approve the pull request | |
| 217 | 217 | by leaving a 👍 reaction on the comment. | |
| 218 | - * Run CI on the pull request. Use the `node-test-pull-request` CI task. | ||
| 218 | + * Optional: Run CI on the pull request. Use the `node-test-pull-request` CI | ||
| 219 | + task. As a convenience, you may apply the `request-ci` label to the pull | ||
| 220 | + request to have a GitHub Actions workflow start the Jenkins CI task for you. | ||
| 219 | 221 | * After two Collaborator approvals for the change and two Collaborator approvals | |
| 220 | 222 | for fast-tracking, land the PR. | |
| 221 | 223 | * If there are not enough approvals within a reasonable time, consider the | |
0 commit comments