doc: update onboarding task - #40570
Closed
Trott wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Make starting Jenkins CI optional.
VoltrexKeyva
approved these changes
Oct 22, 2021
Mesteery
reviewed
Oct 22, 2021
Comment thread
onboarding.md
Outdated
aduh95
reviewed
Oct 22, 2021
Comment thread
onboarding.md
Comment on lines
+219
to
+220
| task. As a convenience, you may apply the `request-ci` label to the pull | ||
| request to have a GitHub Actions workflow start the Jenkins CI task for you. |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
request-ci has no time guarentee, I don't think it would be very convenient for an onboarding session. Maybe that doesn't matter since it's optional anyway, but I wanted to point it out in case you didn't think of it.
Sorry, something went wrong.
aduh95
approved these changes
Oct 23, 2021
gireeshpunathil
approved these changes
Oct 24, 2021
jasnell
approved these changes
Oct 24, 2021
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 24, 2021
Make starting Jenkins CI optional. PR-URL: #40570 Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 6, 2021
Make starting Jenkins CI optional. PR-URL: #40570 Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Nov 25, 2021
Make starting Jenkins CI optional. PR-URL: #40570 Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make starting Jenkins CI optional.