crypto: remove check for condition that is always true · nodejs/node@1e4a2bc · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 1e4a2bc

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

jasnell

committed

crypto: remove check for condition that is always true

The value of `key` will always be `!= null` because earlier in the function, `ERR_CRYPTO_SIGN_KEY_REQUIRED` is thrown if `key` is falsy. Remove condition that subsequently checks that `key != null`. PR-URL: #38072 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 78b6f38 commit 1e4a2bc
Copy full SHA for 1e4a2bc

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/crypto
  • sig.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/crypto/sig.js‎

Copy file name to clipboardExpand all lines: lib/internal/crypto/sig.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -177,7 +177,7 @@ function signOneShot(algorithm, data, key, callback) {
177	177	let keyData;
178	178	if (isKeyObject(key) || isCryptoKey(key)) {
179	179	({ data: keyData } = preparePrivateKey(key));
180		- } else if (key != null && (isKeyObject(key.key) || isCryptoKey(key.key))) {
	180	+ } else if (isKeyObject(key.key) || isCryptoKey(key.key)) {
181	181	({ data: keyData } = preparePrivateKey(key.key));
182	182	} else {
183	183	keyData = createPrivateKey(key)[kHandle];

0 commit comments

Comments

0 (0)