crypto: remove check for condition that is always true - #38072
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The value of `key` will always be `!= null` because earlier in the function, `ERR_CRYPTO_SIGN_KEY_REQUIRED` is thrown if `key` is falsy. Remove condition that subsequently checks that `key != null`.
This comment has been minimized.
aduh95
approved these changes
Apr 4, 2021
This comment has been minimized.
RaisinTen
approved these changes
Apr 4, 2021
cjihrig
approved these changes
Apr 4, 2021
lpinca
approved these changes
Apr 4, 2021
This comment has been minimized.
panva
approved these changes
Apr 5, 2021
jasnell
approved these changes
Apr 6, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
pushed a commit
that referenced
this pull request
Apr 6, 2021
The value of `key` will always be `!= null` because earlier in the function, `ERR_CRYPTO_SIGN_KEY_REQUIRED` is thrown if `key` is falsy. Remove condition that subsequently checks that `key != null`. PR-URL: #38072 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value of key will always be != null because earlier in the
function, ERR_CRYPTO_SIGN_KEY_REQUIRED is thrown if key is falsy.
Remove condition that subsequently checks that key != null.