dns: make promise API fully constructed from `lib/internal/dns/promises` · nodejs/node@2149acd · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 637
• Pull requests 762
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 2149acd

Browse filesBrowse the repository at this point in the historyBrowse files

F3n67u

authored and

targos

committed

dns: make promise API fully constructed from lib/internal/dns/promises

PR-URL: #43227 Refs: https://github.com/nodejs/node/discussions/43198 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

1 parent 9bd13bb commit 2149acd
Copy full SHA for 2149acd

3 files changed

+12-5Lines changed: 12 additions & 5 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • dns.js
  • dns
    • promises.js
  • internal/dns
    • promises.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/dns.js‎

Copy file name to clipboardExpand all lines: lib/dns.js

-2Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -439,8 +439,6 @@ ObjectDefineProperties(module.exports, {
439	439	get() {
440	440	if (promises === null) {
441	441	promises = require('internal/dns/promises');
442		- promises.setServers = defaultResolverSetServers;
443		- promises.setDefaultResultOrder = setDefaultResultOrder;
444	442	}
445	443	return promises;
446	444	}

Collapse file

‎lib/dns/promises.js‎

Copy file name to clipboard

+1-3Lines changed: 1 addition & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -1,5 +1,3 @@
1	1	'use strict';
2	2
3		- const dnsPromises = require('internal/dns/promises');
4		- dnsPromises.setServers = require('dns').setServers;
5		- module.exports = dnsPromises;
	3	+ module.exports = require('internal/dns/promises');

Collapse file

‎lib/internal/dns/promises.js‎

Copy file name to clipboardExpand all lines: lib/internal/dns/promises.js

+11Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -17,6 +17,8 @@ const {
17	17	emitInvalidHostnameWarning,
18	18	getDefaultVerbatim,
19	19	errorCodes: dnsErrorCodes,
	20	+ setDefaultResultOrder,
	21	+ setDefaultResolver,
20	22	} = require('internal/dns/utils');
21	23	const {
22	24	NODATA,
@@ -349,11 +351,20 @@ Resolver.prototype.resolve = function resolve(hostname, rrtype) {
349	351	return ReflectApply(resolver, this, [hostname]);
350	352	};
351	353
	354	+ function defaultResolverSetServers(servers) {
	355	+ const resolver = new Resolver();
	356	+
	357	+ resolver.setServers(servers);
	358	+ setDefaultResolver(resolver);
	359	+ bindDefaultResolver(module.exports, Resolver.prototype);
	360	+ }
352	361
353	362	module.exports = {
354	363	lookup,
355	364	lookupService,
356	365	Resolver,
	366	+ setDefaultResultOrder,
	367	+ setServers: defaultResolverSetServers,
357	368
358	369	// ERROR CODES
359	370	NODATA,

0 commit comments

Comments

0 (0)