dns: make promise API fully constructed from lib/internal/dns/promises - #43227
Merged
nodejs-github-bot merged 1 commit intoJun 20, 2022
Merged
dns: make promise API fully constructed from lib/internal/dns/promises#43227nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
F3n67u
marked this pull request as ready for review
May 28, 2022 06:07
F3n67u
force-pushed
the
fix/dns
branch
2 times, most recently
from
bbb4612 to
eea50fa
Compare
May 28, 2022 06:11
mcollina
approved these changes
May 28, 2022
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
targos
approved these changes
May 28, 2022
lpinca
approved these changes
May 28, 2022
This comment was marked as outdated.
18 tasks
Copy link
Copy Markdown
Contributor
Author
|
Jenkins test is failed, please help to fire another Jenkins try. There is two js test fail: parallel/test-worker-http2-stream-terminate and node-api/test_buffer/test_finalizer. parallel/test-worker-http2-stream-terminate is a known flaky test, see #43084. node-api/test_buffer/test_finalizer is failed 6 times today, perhaps not caused by this pr. |
Sorry, something went wrong.
18 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced May 31, 2022
JungMinu
approved these changes
Jun 3, 2022
21 tasks
F3n67u
force-pushed
the
fix/dns
branch
2 times, most recently
from
280b9d5 to
afa6194
Compare
June 18, 2022 13:16
Copy link
Copy Markdown
Contributor
Author
|
I rebased main branch to resolve a conflict. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
36 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
mcollina
approved these changes
Jun 20, 2022
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
@mcollina thanks for landing this pr. |
Sorry, something went wrong.
This was referenced Jun 21, 2022
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #43227 Refs: https://github.com/nodejs/node/discussions/43198 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 20, 2022
PR-URL: #43227 Refs: https://github.com/nodejs/node/discussions/43198 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #43227 Refs: https://github.com/nodejs/node/discussions/43198 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43227 Refs: https://github.com/nodejs/node/discussions/43198 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr makes the whole promise API be fully constructed from lib/internal/dns/promises.js, it should not be split between lib/dns.js and lib/internal/dns/promises.js.
Refs: https://github.com/nodejs/node/discussions/43198