dgram: fix unhandled exception aborting a closed udp socket · nodejs/node@247dfb7 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 247dfb7

Browse filesBrowse the repository at this point in the historyBrowse files

vramana

authored and

targos

committed

dgram: fix unhandled exception aborting a closed udp socket

Fixes: #46750 PR-URL: #46770 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 92f2f19 commit 247dfb7
Copy full SHA for 247dfb7

2 files changed

+11-1Lines changed: 11 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • dgram.js
• test/parallel
  • test-dgram-abort-closed.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/dgram.js‎

Copy file name to clipboardExpand all lines: lib/dgram.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -139,7 +139,7 @@ function Socket(type, listener) {
139	139	const { signal } = options;
140	140	validateAbortSignal(signal, 'options.signal');
141	141	const onAborted = () => {
142		- this.close();
	142	+ if (this[kStateSymbol].handle) this.close();
143	143	};
144	144	if (signal.aborted) {
145	145	onAborted();

Collapse file

‎test/parallel/test-dgram-abort-closed.js‎

Copy file name to clipboard

+10Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -0,0 +1,10 @@
	1	+ 'use strict';
	2	+ require('../common');
	3	+ const dgram = require('dgram');
	4	+
	5	+ const controller = new AbortController();
	6	+ const socket = dgram.createSocket({ type: 'udp4', signal: controller.signal });
	7	+
	8	+ socket.close();
	9	+
	10	+ controller.abort();

0 commit comments

Comments

0 (0)