FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

dgram: fix unhandled exception aborting a closed udp socket by vramana · Pull Request #46770 · nodejs/node · GitHub

/ node Public

dgram: fix unhandled exception aborting a closed udp socket - #46770

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
vramana:fix-dgram
Feb 25, 2023
ConversationCommits (1)ChecksFiles changed
Merged

dgram: fix unhandled exception aborting a closed udp socket#46770
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
vramana:fix-dgram

Conversation

vramana commented Feb 22, 2023

Copy link
Copy Markdown
Contributor

Fixes: #46750

nodejs-github-bot commented Feb 22, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net

nodejs-github-bot added dgram Issues and PRs related to the dgram subsystem / UDP. needs-ci PRs that need a full CI run. labels Feb 22, 2023

ShogunPanda commented Feb 22, 2023

Copy link
Copy Markdown
Contributor

Can you please add a test for this?

vramana commented Feb 22, 2023

Copy link
Copy Markdown
Contributor Author

@ShogunPanda Does this suffice?

cjihrig reviewed Feb 22, 2023
View reviewed changes
Comment thread test/parallel/test-dgram-abort-closed.js Outdated
mcollina approved these changes Feb 22, 2023
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

cjihrig approved these changes Feb 23, 2023
View reviewed changes

cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM if the CI passes.

ShogunPanda commented Feb 23, 2023

Copy link
Copy Markdown
Contributor

@ShogunPanda Does this suffice?

Absolutely, thanks!

LGTM!

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2023

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view
debadree25 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 23, 2023
github-actions Bot mentioned this pull request Feb 24, 2023
Open
25 tasks

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented Feb 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49988/

github-actions Bot mentioned this pull request Feb 25, 2023
Open
28 tasks
theanarkh added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 25, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 25, 2023
nodejs-github-bot merged commit 65d2a42 into nodejs:main Feb 25, 2023

nodejs-github-bot commented Feb 25, 2023

Copy link
Copy Markdown
Collaborator

Landed in 65d2a42

vramana deleted the fix-dgram branch February 25, 2023 16:13
github-actions Bot mentioned this pull request Feb 26, 2023
Open
15 tasks
This was referenced Feb 27, 2023
Open
Open
targos pushed a commit that referenced this pull request Mar 13, 2023
dgram: fix unhandled exception aborting a closed udp socket
247dfb7 
Fixes: #46750
PR-URL: #46770
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
dgram: fix unhandled exception aborting a closed udp socket
8646b06 
Fixes: #46750
PR-URL: #46770
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams mentioned this pull request Apr 11, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
ShogunPanda ShogunPanda approved these changes
jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. dgram Issues and PRs related to the dgram subsystem / UDP. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Closing UDP socket with abort signal can lead to uncaught exception

9 participants

Back | FazBrowse Home | New Git URL