Commit 262d88e
src: reuse cached env strings in remaining files
Follow-up to #59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by #64760.
Refs: #59891
Refs: #64760
Refs: #64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65039
Refs: #59891
Refs: #64760
Refs: #64912
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 0157c45 commit 262d88e
2 files changed
Lines changed: 3 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1378,11 +1378,7 @@ void CreatePerContextProperties(Local<Object> target, | |||
| 1378 | 1378 | FIXED_ONE_BYTE_STRING(isolate, "dlopen"), | |
| 1379 | 1379 | dlopen_constants) | |
| 1380 | 1380 | .Check(); | |
| 1381 | - os_constants | ||
| 1382 | - ->Set(env->context(), | ||
| 1383 | - FIXED_ONE_BYTE_STRING(isolate, "errno"), | ||
| 1384 | - err_constants) | ||
| 1385 | - .Check(); | ||
| 1381 | + os_constants->Set(env->context(), env->errno_string(), err_constants).Check(); | ||
| 1386 | 1382 | os_constants | |
| 1387 | 1383 | ->Set(env->context(), | |
| 1388 | 1384 | FIXED_ONE_BYTE_STRING(isolate, "signals"), | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -817,10 +817,10 @@ void CreatePerIsolateProperties(IsolateData* isolate_data, | |||
| 817 | 817 | PropertyAttribute read_only = static_cast<PropertyAttribute>( | |
| 818 | 818 | PropertyAttribute::ReadOnly | PropertyAttribute::DontDelete); | |
| 819 | 819 | target->Set(FIXED_ONE_BYTE_STRING(isolate, "LOCK_MODE_SHARED"), | |
| 820 | - FIXED_ONE_BYTE_STRING(isolate, "shared"), | ||
| 820 | + isolate_data->shared_string(), | ||
| 821 | 821 | read_only); | |
| 822 | 822 | target->Set(FIXED_ONE_BYTE_STRING(isolate, "LOCK_MODE_EXCLUSIVE"), | |
| 823 | - FIXED_ONE_BYTE_STRING(isolate, "exclusive"), | ||
| 823 | + isolate_data->exclusive_string(), | ||
| 824 | 824 | read_only); | |
| 825 | 825 | target->Set(FIXED_ONE_BYTE_STRING(isolate, "LOCK_STOLEN_ERROR"), | |
| 826 | 826 | FIXED_ONE_BYTE_STRING(isolate, "LOCK_STOLEN"), | |
0 commit comments