src: update repeated use strings to env by jasnell · Pull Request #64760 · nodejs/node · GitHub

Move strings that are repeated multiple times to env properties

Review requested:

@nodejs/crypto
@nodejs/ffi
@nodejs/security-wg

Signed-off-by: James M Snell <jasnell@gmail.com>

CI: https://ci.nodejs.org/job/node-test-pull-request/75465/

Codecov Report

❌ Patch coverage is 61.53846% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.30%. Comparing base (31cde9f) to head (7090b96).
⚠️ Report is 14 commits behind head on main.

Files with missing lines	Patch %	Lines
src/crypto/crypto_keys.cc	50.00%	1 Missing and 4 partials ⚠️
src/crypto/crypto_context.cc	0.00%	0 Missing and 3 partials ⚠️
src/crypto/crypto_util.cc	33.33%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #64760   +/-   ##
=======================================
  Coverage   90.30%   90.30%           
=======================================
  Files         759      759           
  Lines      247621   247609   -12     
  Branches    46672    46682   +10     
=======================================
+ Hits       223603   223605    +2     
+ Misses      15473    15471    -2     
+ Partials     8545     8533   -12

Files with missing lines	Coverage Δ
src/crypto/crypto_ec.cc	68.54% <100.00%> (ø)
src/crypto/crypto_util.h	67.43% <100.00%> (ø)
src/node_ffi.cc	70.71% <100.00%> (ø)
src/permission/permission.cc	82.56% <100.00%> (ø)
src/crypto/crypto_util.cc	73.37% <33.33%> (+0.19%)	⬆️
src/crypto/crypto_context.cc	72.35% <0.00%> (+0.01%)	⬆️
src/crypto/crypto_keys.cc	70.27% <50.00%> (+0.03%)	⬆️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

CI: https://ci.nodejs.org/job/node-test-pull-request/75488/

Landed in 41afbd3

Follow-up to nodejs#59891, covering files it missed. Overlapping locations (node_ffi.cc, crypto_util.cc) were already handled by nodejs#64760. Refs: nodejs#59891 Refs: nodejs#64760 Refs: nodejs#64912 Signed-off-by: leah-1ee <selee3196@gmail.com>

Follow-up to #59891, covering files it missed. Overlapping locations (node_ffi.cc, crypto_util.cc) were already handled by #64760. Refs: #59891 Refs: #64760 Refs: #64912 Signed-off-by: leah-1ee <selee3196@gmail.com> PR-URL: #65039 Refs: #59891 Refs: #64760 Refs: #64912 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #64760 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>

Follow-up to #59891, covering files it missed. Overlapping locations (node_ffi.cc, crypto_util.cc) were already handled by #64760. Refs: #59891 Refs: #64760 Refs: #64912 Signed-off-by: leah-1ee <selee3196@gmail.com> PR-URL: #65039 Refs: #59891 Refs: #64760 Refs: #64912 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #64760 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>

Follow-up to #59891, covering files it missed. Overlapping locations (node_ffi.cc, crypto_util.cc) were already handled by #64760. Refs: #59891 Refs: #64760 Refs: #64912 Signed-off-by: leah-1ee <selee3196@gmail.com> PR-URL: #65039 Refs: #59891 Refs: #64760 Refs: #64912 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 26, 2026

jasnell force-pushed the jasnell/minor-string-uses branch from 6ee7f78 to 0179359 Compare July 26, 2026 15:18

anonrig approved these changes Jul 26, 2026

View reviewed changes

jasnell force-pushed the jasnell/minor-string-uses branch from 0179359 to 8f79ab7 Compare July 27, 2026 13:56

This comment was marked as outdated.

Sign in to view

src: update repeated use strings to env

7090b96

Signed-off-by: James M Snell <jasnell@gmail.com>

jasnell force-pushed the jasnell/minor-string-uses branch from 8f79ab7 to 7090b96 Compare August 4, 2026 13:38

This comment was marked as outdated.

Sign in to view

panva approved these changes Aug 4, 2026

View reviewed changes

jasnell added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 4, 2026

This comment was marked as outdated.

Sign in to view

jasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 5, 2026

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 5, 2026

nodejs-github-bot merged commit 41afbd3 into nodejs:main Aug 5, 2026
70 of 71 checks passed

leah-1ee mentioned this pull request Aug 5, 2026

src: reuse cached env strings in remaining files #65039

Merged

aduh95 pushed a commit that referenced this pull request Aug 13, 2026

src: update repeated use strings to env

7c6b08a

Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #64760 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>

aduh95 pushed a commit that referenced this pull request Aug 25, 2026

src: update repeated use strings to env

a293dbf

Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #64760 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>

github-actions Bot mentioned this pull request Aug 25, 2026

2026-08-26, Version 26.8.0 (Current) #65551

Merged

src: update repeated use strings to env by jasnell · Pull Request #64760 · nodejs/node · GitHub

Uh oh!

Uh oh!

src: update repeated use strings to env - #64760

src: update repeated use strings to env#64760
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jasnell:jasnell/minor-string-uses

jasnell commented Jul 26, 2026

Uh oh!

nodejs-github-bot commented Jul 26, 2026

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Aug 4, 2026

Uh oh!

codecov Bot commented Aug 4, 2026 •
edited
Loading

Uh oh!

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented Aug 4, 2026 •
edited by jasnell
Loading

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Aug 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

src: update repeated use strings to env by jasnell · Pull Request #64760 · nodejs/node · GitHub

Uh oh!

Uh oh!

src: update repeated use strings to env - #64760

src: update repeated use strings to env#64760nodejs-github-bot merged 1 commit intonodejs:mainnodejs/node:mainfrom jasnell:jasnell/minor-string-usesjasnell/node:jasnell/minor-string-usesCopy head branch name to clipboard

Conversation

jasnell commented Jul 26, 2026

Uh oh!

nodejs-github-bot commented Jul 26, 2026

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Aug 4, 2026

Uh oh!

codecov Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented Aug 4, 2026 • edited by jasnell Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Aug 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

src: update repeated use strings to env#64760
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jasnell:jasnell/minor-string-uses

codecov Bot commented Aug 4, 2026 •
edited
Loading

nodejs-github-bot commented Aug 4, 2026 •
edited by jasnell
Loading