Commit 2a3cca7
cluster: improve for-loop
PR-URL: #26336
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 8b0164a commit 2a3cca7
1 file changed
Lines changed: 5 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -80,10 +80,7 @@ cluster.setupMaster = function(options) { | |||
| 80 | 80 | if (message.cmd !== 'NODE_DEBUG_ENABLED') | |
| 81 | 81 | return; | |
| 82 | 82 | ||
| 83 | - var key; | ||
| 84 | - for (key in cluster.workers) { | ||
| 85 | - const worker = cluster.workers[key]; | ||
| 86 | - | ||
| 83 | + for (const worker of Object.values(cluster.workers)) { | ||
| 87 | 84 | if (worker.state === 'online' || worker.state === 'listening') { | |
| 88 | 85 | process._debugProcess(worker.process.pid); | |
| 89 | 86 | } else { | |
@@ -227,11 +224,10 @@ cluster.disconnect = function(cb) { | |||
| 227 | 224 | if (workers.length === 0) { | |
| 228 | 225 | process.nextTick(() => intercom.emit('disconnect')); | |
| 229 | 226 | } else { | |
| 230 | - for (var key in workers) { | ||
| 231 | - key = workers[key]; | ||
| 232 | - | ||
| 233 | - if (cluster.workers[key].isConnected()) | ||
| 234 | - cluster.workers[key].disconnect(); | ||
| 227 | + for (const worker of Object.values(cluster.workers)) { | ||
| 228 | + if (worker.isConnected()) { | ||
| 229 | + worker.disconnect(); | ||
| 230 | + } | ||
| 235 | 231 | } | |
| 236 | 232 | } | |
| 237 | 233 | ||
0 commit comments