cluster: improve for-loop - #26336
Closed
gengjiawen wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
lpinca
approved these changes
Feb 27, 2019
targos
approved these changes
Feb 27, 2019
Copy link
Copy Markdown
Member
|
Since we're not using the keys, it might be even better to do for (const worker of Object.values(cluster.workers)? |
Sorry, something went wrong.
gengjiawen
force-pushed
the
cluster_for_loop
branch
from
3f4394a to
ea2892b
Compare
February 28, 2019 16:32
BridgeAR
approved these changes
Feb 28, 2019
targos
approved these changes
Feb 28, 2019
Copy link
Copy Markdown
Member
Sorry, something went wrong.
ChALkeR
approved these changes
Mar 1, 2019
ChALkeR
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Perhaps also update these lines:
https://github.com/nodejs/node/blob/ea2892bf7beff4e0583df898cfb6b22b45b884a5/lib/internal/cluster/master.js#L227-L228
Sorry, something went wrong.
gengjiawen
force-pushed
the
cluster_for_loop
branch
from
ea2892b to
9bb7dac
Compare
March 1, 2019 15:13
gengjiawen
force-pushed
the
cluster_for_loop
branch
from
9bb7dac to
5d8c296
Compare
March 1, 2019 15:16
gengjiawen
force-pushed
the
cluster_for_loop
branch
from
5d8c296 to
879e60a
Compare
March 1, 2019 15:18
Copy link
Copy Markdown
Member
Sorry, something went wrong.
jasnell
approved these changes
Mar 2, 2019
Copy link
Copy Markdown
Member
Sorry, something went wrong.
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 5, 2019
PR-URL: nodejs#26336 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 12, 2019
PR-URL: nodejs#26336 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 16, 2019
PR-URL: #26336 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced May 29, 2019
This was referenced May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist