src: replace static const string_view by static constexpr · nodejs/node@2c2b6d1 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 2c2b6d1

Browse filesBrowse the repository at this point in the historyBrowse files

lemire

authored and

MoLow

committed

src: replace static const string_view by static constexpr

PR-URL: #47524 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 3840bb5 commit 2c2b6d1
Copy full SHA for 2c2b6d1

1 file changed

+4-1Lines changed: 4 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • json_utils.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/json_utils.cc‎

Copy file name to clipboardExpand all lines: src/json_utils.cc

+4-1Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -3,7 +3,10 @@
3	3	namespace node {
4	4
5	5	std::string EscapeJsonChars(std::string_view str) {
6		- static const std::string_view control_symbols[0x20] = {
	6	+ // 'static constexpr' is slightly better than static const
	7	+ // since the initialization occurs at compile time.
	8	+ // See https://lemire.me/blog/I3Cah
	9	+ static constexpr std::string_view control_symbols[0x20] = {
7	10	"\\u0000", "\\u0001", "\\u0002", "\\u0003", "\\u0004", "\\u0005",
8	11	"\\u0006", "\\u0007", "\\b", "\\t", "\\n", "\\u000b",
9	12	"\\f", "\\r", "\\u000e", "\\u000f", "\\u0010", "\\u0011",

0 commit comments

Comments

0 (0)