nodejs
diff --git a/‎src/async_wrap-inl.h‎
Lines changed: 2 additions & 3 deletions b/‎src/async_wrap-inl.h‎
Lines changed: 2 additions & 3 deletions
@@ -74,9 +74,8 @@ inline v8::MaybeLocal<v8::Value> AsyncWrap::MakeCallback(
   if (!object()->Get(env()->context(), symbol).ToLocal(&cb_v))
     return v8::MaybeLocal<v8::Value>();
   if (!cb_v->IsFunction()) {
-    // TODO(addaleax): We should throw an error here to fulfill the
-    // `MaybeLocal<>` API contract.
-    return v8::MaybeLocal<v8::Value>();
+    v8::Isolate* isolate = env()->isolate();
+    return Undefined(isolate);
   }
   return MakeCallback(cb_v.As<v8::Function>(), argc, argv);
 }
Original file line number	Diff line number	Diff line change
@@ -74,9 +74,8 @@ inline v8::MaybeLocal<v8::Value> AsyncWrap::MakeCallback(
74	74	if (!object()->Get(env()->context(), symbol).ToLocal(&cb_v))
75	75	return v8::MaybeLocal<v8::Value>();
76	76	if (!cb_v->IsFunction()) {
77		- // TODO(addaleax): We should throw an error here to fulfill the
78		- // `MaybeLocal<>` API contract.
79		- return v8::MaybeLocal<v8::Value>();
	77	+ v8::Isolate* isolate = env()->isolate();
	78	+ return Undefined(isolate);
80	79	}
81	80	return MakeCallback(cb_v.As<v8::Function>(), argc, argv);
82	81	}