FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: handle bad callback in asyc_wrap by HarshithaKP · Pull Request #31946 · nodejs/node · GitHub

/ node Public

src: handle bad callback in asyc_wrap - #31946

Closed
HarshithaKP wants to merge 2 commits into
nodejs:masterfrom
HarshithaKP:asyc_wrap_inl_throw_error
ConversationCommits (2)ChecksFiles changed
Closed

src: handle bad callback in asyc_wrap#31946
HarshithaKP wants to merge 2 commits into
nodejs:masterfrom
HarshithaKP:asyc_wrap_inl_throw_error

Conversation

HarshithaKP commented Feb 25, 2020

Copy link
Copy Markdown
Member

src: handle bad callback in asyc_wrap

Align with the MaybeLocal<> API contract
Refs:

node/deps/v8/include/v8.h

Lines 345 to 349 in 9403250

* If an API method returns a MaybeLocal<>, the API method can potentially fail
* either because an exception is thrown, or because an exception is pending,
* e.g. because a previous API call threw an exception that hasn't been caught
* yet, or because a TerminateExecution exception was thrown. In that case, an
* empty MaybeLocal is returned.

addresses an @addaleax 's TODO

src: elevate v8 namespaces

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 25, 2020
addaleax reviewed Feb 26, 2020
View reviewed changes
Comment thread test/parallel/test-zlib-brotli.js Outdated
addaleax reviewed Feb 27, 2020
View reviewed changes
Comment thread src/async_wrap-inl.h Outdated

addaleax Feb 27, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We don’t add using statements to headers (we should probably have a linter rule against that, at least for the v8 symbols…)

HarshithaKP Feb 27, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@addaleax, grep "using v8::" src/*.h

I am seeing this pattern in few files already. If I remove using phrase, is there any way I can elevate ?

addaleax Feb 27, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes, these other files should also not use it.

There are no shorthands in that case, we do spell out the entire type in headers.

HarshithaKP Feb 27, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@addaleax,thanks. Reverted the changes. What is the rationale for this ?

HarshithaKP Feb 27, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I mean, why we want to skip for headers ? Is there any performance reason or something else ?

addaleax Feb 27, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@HarshithaKP Because then the symbols are available in any source file that includes this header, even if that’s not obvious. For example, this code would fail to compile if example.h has a using v8::Array; line:

#include "example.h"

class Array {};

Comment thread src/async_wrap-inl.h Outdated
Comment thread src/async_wrap-inl.h Outdated
src: Handle bad callback in asyc_wrap
fc53c8d 
Align with the MaybeLocal<> API contract
HarshithaKP force-pushed the asyc_wrap_inl_throw_error branch from 2a91f94 to fc53c8d Compare February 27, 2020 10:16
addaleax approved these changes Feb 27, 2020
View reviewed changes
Comment thread src/async_wrap-inl.h Outdated
addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 4, 2020

nodejs-github-bot commented Mar 4, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29533/

gireeshpunathil pushed a commit that referenced this pull request Mar 5, 2020
src: Handle bad callback in asyc_wrap
757e203 
Align with the MaybeLocal<> API contract

PR-URL: #31946
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

gireeshpunathil commented Mar 5, 2020

Copy link
Copy Markdown
Member

landed in 757e203

MylesBorins pushed a commit that referenced this pull request Mar 9, 2020
src: Handle bad callback in asyc_wrap
31e4a0d 
Align with the MaybeLocal<> API contract

PR-URL: #31946
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Mar 10, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 16, 2020
src: Handle bad callback in asyc_wrap
8728a40 
Align with the MaybeLocal<> API contract

PR-URL: #31946
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
src: Handle bad callback in asyc_wrap
eaa730c 
Align with the MaybeLocal<> API contract

PR-URL: #31946
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 23, 2020
src: Handle bad callback in asyc_wrap
708dafa 
Align with the MaybeLocal<> API contract

PR-URL: #31946
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 30, 2020
src: Handle bad callback in asyc_wrap
808379c 
Align with the MaybeLocal<> API contract

PR-URL: #31946
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
jasnell jasnell approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL