FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix tap escaping with and without --test · nodejs/node@32b020c · GitHub

/ node Public

Commit 32b020c

Browse files
pulkit-30
authored and
juanarbol
committed
test: fix tap escaping with and without --test
PR-URL: #46311 Backport-PR-URL: #46839 Fixes: #45836 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
1 parent 63563f8 commit 32b020c

3 files changed

Lines changed: 9 additions & 9 deletions

File tree

‎lib/internal/test_runner/reporter/tap.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -132,14 +132,14 @@ function indent(nesting) {
132132

133133
// In certain places, # and \ need to be escaped as \# and \\.
134134
function tapEscape(input) {
135-
let result = StringPrototypeReplaceAll(input, '\\', '\\\\');
136-
result = StringPrototypeReplaceAll(result, '#', '\\#');
137-
result = StringPrototypeReplaceAll(result, '\b', '\\b');
135+
let result = StringPrototypeReplaceAll(input, '\b', '\\b');
138136
result = StringPrototypeReplaceAll(result, '\f', '\\f');
139137
result = StringPrototypeReplaceAll(result, '\t', '\\t');
140138
result = StringPrototypeReplaceAll(result, '\n', '\\n');
141139
result = StringPrototypeReplaceAll(result, '\r', '\\r');
142140
result = StringPrototypeReplaceAll(result, '\v', '\\v');
141+
result = StringPrototypeReplaceAll(result, '\\', '\\\\');
142+
result = StringPrototypeReplaceAll(result, '#', '\\#');
143143
return result;
144144
}
145145

‎test/message/test_runner_output.out‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -346,8 +346,8 @@ ok 36 - functionAndOptions # SKIP
346346
---
347347
duration_ms: *
348348
...
349-
# Subtest: escaped description \\ \# \\\#\\ \n \t \f \v \b \r
350-
ok 37 - escaped description \\ \# \\\#\\ \n \t \f \v \b \r
349+
# Subtest: escaped description \\ \# \\\#\\ \\n \\t \\f \\v \\b \\r
350+
ok 37 - escaped description \\ \# \\\#\\ \\n \\t \\f \\v \\b \\r
351351
---
352352
duration_ms: *
353353
...

‎test/message/test_runner_output_cli.out‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -122,9 +122,9 @@ TAP version 13
122122
failureType: 'testCodeFailure'
123123
error: |-
124124
Expected values to be strictly equal:
125-
125+
126126
true !== false
127-
127+
128128
code: 'ERR_ASSERTION'
129129
expected: false
130130
actual: true
@@ -345,8 +345,8 @@ TAP version 13
345345
---
346346
duration_ms: *
347347
...
348-
# Subtest: escaped description \\ \# \\\#\\ n \\t f \\v b \\r
349-
ok 37 - escaped description \\ \# \\\#\\ n \\t f \\v b \\r
348+
# Subtest: escaped description \\ \# \\\#\\ \\n \\t \\f \\v \\b \\r
349+
ok 37 - escaped description \\ \# \\\#\\ \\n \\t \\f \\v \\b \\r
350350
---
351351
duration_ms: *
352352
...

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL