FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix tap escaping with and without --test by pulkit-30 · Pull Request #46311 · nodejs/node · GitHub

/ node Public

test: fix tap escaping with and without --test - #46311

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
pulkit-30:fix-45836
Jan 28, 2023
ConversationCommits (1)ChecksFiles changed
Merged

test: fix tap escaping with and without --test#46311
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
pulkit-30:fix-45836

Conversation

pulkit-30 commented Jan 23, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

fix: #45836

code

const test = require('node:test');
test('escaped description \\ # \\#\\ \n \t \f \v \b \r');
  • tap escaping without --test
TAP version 13
# Subtest: escaped description \\ \# \\\#\\ \\n \\t \\f \\v \\b \\r
ok 1 - escaped description \\ \# \\\#\\ \\n \\t \\f \\v \\b \\r
  ---
  duration_ms: 3.569875
  ...
1..1
# tests 1
# pass 1
# fail 0
# cancelled 0
# skipped 0
# todo 0
# duration_ms 6.989541
  • tap escaping with --test
TAP version 13
# Subtest: /Users/pulkitgupta/Desktop/node/test.js
    # Subtest: escaped description \\ \# \\\#\\ \\n \\t \\f \\v \\b \\r
    ok 1 - escaped description \\ \# \\\#\\ \\n \\t \\f \\v \\b \\r
      ---
      duration_ms: 2.582292
      ...
    1..1
ok 1 - /Users/pulkitgupta/Desktop/node/test.js
  ---
  duration_ms: 49.498875
  ...
1..1
# tests 1
# pass 1
# fail 0
# cancelled 0
# skipped 0
# todo 0
# duration_ms 50.930334

Also modify test output's [test/message/test_runner_output.out , test/message/test_runner_output_cli.out]

nodejs-github-bot commented Jan 23, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

nodejs-github-bot added dont-land-on-v14.x needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Jan 23, 2023
benjamingr reviewed Jan 24, 2023
View reviewed changes

benjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Maybe add a test that running with and without --test produces the same output?

pulkit-30 commented Jan 24, 2023

Copy link
Copy Markdown
Contributor Author

Hey @benjamingr,
Thanks for the review,
Already there are tests for this (test_runner_output.js, test_runner_output_cli.js), that runs with and without --test flag,
I have modified output for these tests to ensure consistent/same output with and without --test flag.

Please let me know if more tests are required for the same;

MoLow requested a review from benjamingr January 26, 2023 07:42
MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 26, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 26, 2023
benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 28, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 28, 2023

nodejs-github-bot commented Jan 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49219/

nodejs-github-bot commented Jan 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49220/

MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 28, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 28, 2023
nodejs-github-bot merged commit 2f38c74 into nodejs:main Jan 28, 2023

nodejs-github-bot commented Jan 28, 2023

Copy link
Copy Markdown
Collaborator

Landed in 2f38c74

ruyadorno pushed a commit that referenced this pull request Feb 1, 2023
test: fix tap escaping with and without --test
8a45c9d 
PR-URL: #46311
Fixes: #45836
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
ruyadorno mentioned this pull request Feb 1, 2023
Merged
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 7, 2023
test: fix tap escaping with and without --test
dfca2fd 
PR-URL: nodejs/node#46311
Fixes: nodejs/node#45836
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
(cherry picked from commit 2f38c74e263ed2e7f3b087efb9adee2442dd25c4)
MoLow pushed a commit to nodejs/node-core-test that referenced this pull request Feb 8, 2023
test: fix tap escaping with and without --test
69e4f83 
PR-URL: nodejs/node#46311
Fixes: nodejs/node#45836
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
(cherry picked from commit 2f38c74e263ed2e7f3b087efb9adee2442dd25c4)
MoLow pushed a commit to MoLow/node that referenced this pull request Feb 25, 2023
test: fix tap escaping with and without --test
95250e1 
PR-URL: nodejs#46311
Fixes: nodejs#45836
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
test: fix tap escaping with and without --test
fa7933e 
PR-URL: #46311
Backport-PR-URL: #46839
Fixes: #45836
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
juanarbol mentioned this pull request Mar 3, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
test: fix tap escaping with and without --test
32b020c 
PR-URL: #46311
Backport-PR-URL: #46839
Fixes: #45836
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

benjamingr benjamingr approved these changes
MoLow MoLow approved these changes

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tap escaping not consistent with and without --test

4 participants

Back | FazBrowse Home | New Git URL