v19.6.0 proposal by ruyadorno · Pull Request #46455 · nodejs/node · GitHub

2023-02-02, Version 19.6.0 (Current), @ruyadorno

Notable changes

ESM: Leverage loaders when resolving subsequent loaders

Loaders now apply to subsequent loaders, for example: --experimental-loader ts-node --experimental-loader loader-written-in-typescript.

Upgrade npm to 9.4.0

Added --install-strategy=linked option for installations similar to pnpm.

Other notable changes

[a7c9daa497] - (SEMVER-MINOR) fs: add statfs() functions (Colin Ihrig) #46358
[34d70ce615] - (SEMVER-MINOR) vm: expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320
[b4ac794923] - (SEMVER-MINOR) v8: support gc profile (theanarkh) #46255
[d52f60009a] - (SEMVER-MINOR) src,lib: add constrainedMemory API for process (theanarkh) #46218
[5ad6c2088e] - (SEMVER-MINOR) buffer: add isAscii method (Yagiz Nizipli) #46046
[fbdc3f7316] - (SEMVER-MINOR) test_runner: add reporters (Moshe Atlow) #45712

Commits

[524eec70e2] - benchmark: add trailing commas (Antoine du Hamel) #46370
[f318a85408] - benchmark: remove buffer benchmarks redundancy (Brian White) #45735
[6186b3ea14] - benchmark: introduce benchmark combination filtering (Brian White) #45735
[5ad6c2088e] - (SEMVER-MINOR) buffer: add isAscii method (Yagiz Nizipli) #46046
[8c6c4338a6] - build: export more OpenSSL symbols on Windows (Mohamed Akram) #45486
[d795d93901] - build: fix MSVC 2022 Release compilation (Vladimir Morozov (REDMOND)) #46228
[8e363cf8e8] - crypto: include hmac.h in crypto_util.h (Adam Langley) #46279
[c1f3e13c65] - deps: update acorn to 8.8.2 (Node.js GitHub Bot) #46363
[813b160bd7] - deps: upgrade npm to 9.4.0 (npm team) #46353
[9c2f3cea70] - deps: update undici to 5.15.0 (Node.js GitHub Bot) #46213
[312e10c1e3] - deps: update to uvwasi 0.0.15 (Colin Ihrig) #46253
[c7024eec16] - doc: correct the sed command for macOS in release process docs (Juan José) #46397
[996bac044b] - doc: include webstreams in finished() and Duplex.from() parameters (Debadree Chatterjee) #46312
[891d18d55c] - doc: pass string to textEncoder.encode as input (Deokjin Kim) #46421
[968db213f8] - doc: add tip for session.post function (theanarkh) #46354
[a64d7f4e31] - doc: add documentation for socket.destroySoon() (Luigi Pinca) #46337
[975788899f] - doc: fix commit message using test instead of deps (Tony Gorez) #46313
[1d44017f52] - doc: add v8 fast api contribution guidelines (Yagiz Nizipli) #46199
[e2698c05fb] - doc: fix small typo error (0xflotus) #46186
[f39fb8c001] - doc: mark some parameters as optional in webstreams (Deokjin Kim) #46269
[7a9af38128] - doc: update output of example in events.getEventListeners (Deokjin Kim) #46268
[729642f30b] - esm: delete preload mock test (Geoffrey Booth) #46402
[7aac21e90a] - esm: leverage loaders when resolving subsequent loaders (Maël Nison) #43772
[a7c9daa497] - (SEMVER-MINOR) fs: add statfs() functions (Colin Ihrig) #46358
[1ec6270efa] - http: res.setHeaders first implementation (Marco Ippolito) #46109
[d4370259e9] - inspector: allow opening inspector when NODE_V8_COVERAGE is set (Moshe Atlow) #46113
[b966ef9a42] - lib: remove unnecessary ObjectGetValueSafe (Chengzhong Wu) #46335
[2b06d66289] - lib: cache parsed source maps to reduce memory footprint (Chengzhong Wu) #46225
[c38673df91] - meta: update AUTHORS (Node.js GitHub Bot) #46399
[c10e602547] - meta: update AUTHORS (Node.js GitHub Bot) #46303
[9dc026b14a] - meta: add .mailmap entry (Rich Trott) #46303
[7c514574f7] - meta: move evanlucas to emeritus (Evan Lucas) #46274
[3a3a6d87f1] - module: move test reporter loading (Geoffrey Booth) #45923
[4ae2492a33] - readline: fix detection of carriage return (Antoine du Hamel) #46306
[43cad78b7a] - src: stop tracing agent before shutting down libuv (Santiago Gimeno) #46380
[360a3f3094] - src: get rid of fp arithmetic in ParseIPv4Host (Tobias Nießen) #46326
[e7b507a8cf] - src: use UNREACHABLE instead of CHECK(falsy) (Tobias Nießen) #46317
[4c59b60ee8] - src: add support for ETW stack walking (José Dapena Paz) #46203
[640d111f95] - src: refactor EndsInANumber in node_url.cc and adds IsIPv4NumberValid (Miguel Teixeira) #46227
[fb7bee2b6e] - src: fix c++ exception on bad command line arg (Ben Noordhuis) #46290
[18c95ec4bd] - src: remove unreachable UNREACHABLE (Tobias Nießen) #46281
[35bf93b01a] - src: replace custom ASCII validation with simdutf one (Anna Henningsen) #46271
[8307a4bbcd] - src: replace unreachable code with static_assert (Tobias Nießen) #46250
[7cf0da020a] - src: use explicit C++17 fallthrough (Tobias Nießen) #46251
[d52f60009a] - (SEMVER-MINOR) src,lib: add constrainedMemory API for process (theanarkh) #46218
[2e5e7a9261] - stream: remove brandchecks from stream duplexify (Debadree Chatterjee) #46315
[9675863461] - stream: fix readable stream as async iterator function (Erick Wendel) #46147
[232bdd5d16] - test: add trailing commas in test/node-api (Antoine du Hamel) #46384
[4cc081815d] - test: add trailing commas in test/message (Antoine du Hamel) #46372
[b83c5d9deb] - test: add trailing commas in test/pseudo-tty (Antoine du Hamel) #46371
[8a45c9d231] - test: fix tap escaping with and without --test (Pulkit Gupta) #46311
[367dc41299] - test: set common.bits to 64 for loong64 (Shi Pujin) #45383
[7385edc7d0] - test: s390x zlib test case fixes (Adam Majer) #46367
[d5d837bdee] - test: fix logInTimeout is not function (theanarkh) #46348
[a1d79546ac] - test: avoid trying to call sysctl directly (Adam Majer) #46366
[747f3689e0] - test: avoid left behind child processes (Richard Lau) #46276
[940484b7aa] - test: add failing test for readline with carriage return (Alec Mev) #46075
[d13116a719] - test,crypto: add CFRG curve vectors to wrap/unwrap tests (Filip Skokan) #46406
[398a7477b3] - test,crypto: update WebCryptoAPI WPT (Filip Skokan) #46267
[8b473affe8] - test_runner: make built in reporters internal (Colin Ihrig) #46092
[a49e17e22b] - test_runner: report file in test runner events (Moshe Atlow) #46030
[fbdc3f7316] - test_runner: add reporters (Moshe Atlow) #45712
[6579de8c47] - tools: update eslint to 8.33.0 (Node.js GitHub Bot) #46400
[bf62da55ad] - tools: update doc to unist-util-select@4.0.3 unist-util-visit@4.1.2 (Node.js GitHub Bot) #46364
[b0acf55197] - tools: update lint-md-dependencies to rollup@3.12.0 (Node.js GitHub Bot) #46398
[88b904cf24] - tools: require more trailing commas (Antoine du Hamel) #46346
[4440b3ef87] - tools: update lint-md-dependencies (Node.js GitHub Bot) #46302
[e75faff4bd] - tools: allow icutrim.py to run on python2 (Michael Dawson) #46263
[e460d16d73] - url: refactor to use more primordials (Antoine du Hamel) #45966
[b4ac794923] - (SEMVER-MINOR) v8: support gc profile (theanarkh) #46255
[34d70ce615] - (SEMVER-MINOR) vm: expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320

Backport-PR-URL: #46272 PR-URL: #46109 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

Backport-PR-URL: #46361 PR-URL: #45712 Fixes: #45648 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Move the logic for handling --test-reporter out of the general module loader and into the test_runner subsystem. Backport-PR-URL: #46361 PR-URL: #45923 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Backport-PR-URL: #46361 PR-URL: #46030 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

This commit updates the test runner to make the built in test reporters internal modules. Backport-PR-URL: #46361 PR-URL: #46092 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

PR-URL: #43772 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>

PR-URL: #46046 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Since v19.2 it's not possible to use readableStreams as async iterators (confirmed bug). This patch fixes the problem by reading the Stream.Duplex property from 'streams/duplex' instead of 'streams/legacy' module Fixes: #46141 PR-URL: #46147 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

This passes the strictest -Wimplicit-fallthrough setting. PR-URL: #46251 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Notable changes: - Use GetThreadTimes() on Windows for CLOCK_THREAD_CPUTIME_ID. - Increase the precision of the process and thread clocks on Windows. PR-URL: #46253 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

This function divides an unsigned 32-bit integer by 8, effectively right-shifting it by three bits, so the result must be less than INT_MAX. Refs: #46209 PR-URL: #46250 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

PR-URL: #46267 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Update mismatched output of `events.getEventListeners` example. Plus, show output using console.log. PR-URL: #46268 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Some parameters are described as optional in spec, so update mismatched parameter. Refs: https://streams.spec.whatwg.org/ PR-URL: #46269 Refs: https://streams.spec.whatwg.org/ Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #46271 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Darshan Sen <raisinten@gmail.com>

PR-URL: #46274 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Refs: nodejs/build#2998 Small icu seems broken from 14.x since it uses python2. Although main no longer supports python2 landing and backporting this change to the 14.x line would allow us to simplify future backports as currently the files are the same across lines. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #46263 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

`crypto_util.h` references `HMAC_CTX_free` but doesn't include the header file that contains it. PR-URL: #46279 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

All paths leading up to this UNREACHABLE either return or abort. (If they did not, the compiler would at least emit a warning.) PR-URL: #46281 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

PR-URL: #46186 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

PR-URL: #45735 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

PR-URL: #46075 Refs: #45992 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Replace stoull() with strtoull(). The former throws an exception when the input is malformed, the latter doesn't. Fixes: #46223 PR-URL: #46290 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #46303 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

This also improves performance to map the stack trace when the `Error.stack` is accessed. PR-URL: #46225 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Extend the Linux logic to all POSIX platforms in test-child-process-exec-abortcontroller-promisified. PR-URL: #46276 Fixes: nodejs/build#3154 Refs: #37518 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Update to @rollup/plugin-commonjs@24.0.1 and rollup@3.10.1. PR-URL: #46302 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: #45966 Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

PR-URL: #46400 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #46402 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

PR-URL: #45486 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

PR-URL: #46406 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>

Otherwise there might be pending tracing fs writes which lead to a crash because the libuv threadpool is already gone. Fixes: #46376 PR-URL: #46380 Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #46312 Refs: #46190 Refs: #46205 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: #46397 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

Review requested:

@nodejs/actions

Notable changes: esm: * leverage loaders when resolving subsequent loaders (Maël Nison) #43772 fs: * (SEMVER-MINOR) add statfs() functions (Colin Ihrig) #46358 test_runner: * add reporters (Moshe Atlow) #45712 PR-URL: #46455

CI: https://ci.nodejs.org/job/node-test-pull-request/49289/
CITGM: https://ci.nodejs.org/job/citgm-smoker/3085/
CITGM (v19.x): https://ci.nodejs.org/job/citgm-smoker/3086/

Looks this notable change nodejs/node@8c6c433 (#46455) not showing in log

Looks this notable change nodejs/node@8c6c433 (#46455) not showing in log

thanks for the note @gengjiawen, following up in the PR!

Notable changes: buffer: * (SEMVER-MINOR) add isAscii method (Yagiz Nizipli) #46046 deps: * upgrade npm to 9.4.0 (npm team) #46353 esm: * leverage loaders when resolving subsequent loaders (Maël Nison) #43772 fs: * (SEMVER-MINOR) add statfs() functions (Colin Ihrig) #46358 src,lib: * (SEMVER-MINOR) add constrainedMemory API for process (theanarkh) #46218 test_runner: * (SEMVER-MINOR) add reporters (Moshe Atlow) #45712 v8: * (SEMVER-MINOR) support gc profile (theanarkh) #46255 vm: * (SEMVER-MINOR) expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320 PR-URL: #46455

PR-URL: #46455

Notable changes: buffer: * (SEMVER-MINOR) add isAscii method (Yagiz Nizipli) #46046 deps: * upgrade npm to 9.4.0 (npm team) #46353 esm: * leverage loaders when resolving subsequent loaders (Maël Nison) #43772 fs: * (SEMVER-MINOR) add statfs() functions (Colin Ihrig) #46358 src,lib: * (SEMVER-MINOR) add constrainedMemory API for process (theanarkh) #46218 test_runner: * (SEMVER-MINOR) add reporters (Moshe Atlow) #45712 v8: * (SEMVER-MINOR) support gc profile (theanarkh) #46255 vm: * (SEMVER-MINOR) expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320 PR-URL: #46455

Refs: nodejs/node#46455

marco-ippolito and others added 30 commits January 31, 2023 17:13

http: res.setHeaders first implementation

1ec6270

Backport-PR-URL: #46272 PR-URL: #46109 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

test_runner: add reporters

fbdc3f7

Backport-PR-URL: #46361 PR-URL: #45712 Fixes: #45648 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

test_runner: report file in test runner events

a49e17e

Backport-PR-URL: #46361 PR-URL: #46030 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

esm: leverage loaders when resolving subsequent loaders

7aac21e

PR-URL: #43772 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>

buffer: add isAscii method

5ad6c20

PR-URL: #46046 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

test,crypto: update WebCryptoAPI WPT

398a747

PR-URL: #46267 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

test: add failing test for readline with carriage return

940484b

PR-URL: #46075 Refs: #45992 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

meta: add .mailmap entry

9dc026b

PR-URL: #46303 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

meta: update AUTHORS

c10e602

PR-URL: #46303 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

tools: update lint-md-dependencies

4440b3e

Update to @rollup/plugin-commonjs@24.0.1 and rollup@3.10.1. PR-URL: #46302 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

url: refactor to use more primordials

e460d16

PR-URL: #45966 Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

nodejs-github-bot and others added 7 commits January 31, 2023 18:18

esm: delete preload mock test

729642f

PR-URL: #46402 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

build: export more OpenSSL symbols on Windows

8c6c433

PR-URL: #45486 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

test,crypto: add CFRG curve vectors to wrap/unwrap tests

d13116a

PR-URL: #46406 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>

doc: include webstreams in finished() and Duplex.from() parameters

996bac0

PR-URL: #46312 Refs: #46190 Refs: #46205 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

doc: correct the sed command for macOS in release process docs

c7024ee

PR-URL: #46397 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

nodejs-github-bot added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. v19.x labels Feb 1, 2023

ruyadorno force-pushed the v19.6.0-proposal branch from a61a25c to 8b59e6c Compare February 1, 2023 03:24

ruyadorno added the release Issues and PRs related to Node.js releases. label Feb 1, 2023

ruyadorno mentioned this pull request Feb 1, 2023

build: export more OpenSSL symbols on Windows #45486

Merged

ruyadorno force-pushed the v19.6.0-proposal branch from 8b59e6c to 3ecd96f Compare February 1, 2023 18:19

richardlau approved these changes Feb 1, 2023

View reviewed changes

RafaelGSS approved these changes Feb 1, 2023

View reviewed changes

BethGriggs approved these changes Feb 1, 2023

View reviewed changes

ruyadorno merged commit 3ecd96f into v19.x Feb 2, 2023

ruyadorno deleted the v19.6.0-proposal branch February 2, 2023 16:01

ruyadorno added a commit that referenced this pull request Feb 2, 2023

Working on v19.6.1

6ac86a4

PR-URL: #46455

ruyadorno mentioned this pull request Feb 2, 2023

Blog: v19.6.0 release post nodejs/nodejs.org#5036

Merged

ruyadorno added a commit to ruyadorno/nodejs.org that referenced this pull request Feb 2, 2023

Blog: v19.6.0 release post

3465d9f

Refs: nodejs/node#46455

richardlau pushed a commit to nodejs/nodejs.org that referenced this pull request Feb 2, 2023

Blog: v19.6.0 release post (#5036 )

e60a406

Refs: nodejs/node#46455

v19.6.0 proposal by ruyadorno · Pull Request #46455 · nodejs/node · GitHub

Uh oh!

Uh oh!

v19.6.0 proposal - #46455

v19.6.0 proposal#46455
ruyadorno merged 72 commits into
v19.xfrom
v19.6.0-proposal

ruyadorno commented Feb 1, 2023 •
edited
Loading

Uh oh!

Uh oh!

nodejs-github-bot commented Feb 1, 2023

Uh oh!

nodejs-github-bot commented Feb 1, 2023 •
edited by ruyadorno
Loading

Uh oh!

Uh oh!

gengjiawen commented Feb 1, 2023 •
edited
Loading

Uh oh!

Uh oh!

ruyadorno commented Feb 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

v19.6.0 proposal by ruyadorno · Pull Request #46455 · nodejs/node · GitHub

Uh oh!

Uh oh!

v19.6.0 proposal - #46455

v19.6.0 proposal#46455ruyadorno merged 72 commits intov19.xnodejs/node:v19.xfrom v19.6.0-proposalnodejs/node:v19.6.0-proposalCopy head branch name to clipboard

Conversation

ruyadorno commented Feb 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

2023-02-02, Version 19.6.0 (Current), @ruyadorno

Notable changes

ESM: Leverage loaders when resolving subsequent loaders

Upgrade npm to 9.4.0

Other notable changes

Commits

Uh oh!

nodejs-github-bot commented Feb 1, 2023

Uh oh!

nodejs-github-bot commented Feb 1, 2023 • edited by ruyadorno Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gengjiawen commented Feb 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ruyadorno commented Feb 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

v19.6.0 proposal#46455
ruyadorno merged 72 commits into
v19.xfrom
v19.6.0-proposal

ruyadorno commented Feb 1, 2023 •
edited
Loading

nodejs-github-bot commented Feb 1, 2023 •
edited by ruyadorno
Loading

gengjiawen commented Feb 1, 2023 •
edited
Loading