FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix logInTimeout is not function by theanarkh · Pull Request #46348 · nodejs/node · GitHub

/ node Public

test: fix logInTimeout is not function - #46348

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
theanarkh:fix_test_case
Jan 28, 2023
ConversationCommits (1)ChecksFiles changed
Merged

test: fix logInTimeout is not function#46348
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
theanarkh:fix_test_case

Conversation

theanarkh commented Jan 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

fix logInTimeout is not function in test-child-process-exec-timeout-kill.js.
cc @joyeecheung
Refs: #44390

The error is as follows.

[stdout]
[stderr] /home/iojs/build/workspace/node-test-commit-linuxone/test/parallel/test-child-process-exec-timeout-kill.js:17
  logInTimeout(kExpiringChildRunTime);
  ^

TypeError: logInTimeout is not a function
    at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linuxone/test/parallel/test-child-process-exec-timeout-kill.js:17:3)
    at Module._compile (node:internal/modules/cjs/loader:1246:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1300:10)
    at Module.load (node:internal/modules/cjs/loader:1103:32)
    at Module._load (node:internal/modules/cjs/loader:942:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:83:12)
    at node:internal/main/run_main_module:23:47
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 25, 2023
lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 25, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 25, 2023
theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 26, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 26, 2023

This comment was marked as outdated.

Sign in to view
richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 26, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 26, 2023

nodejs-github-bot commented Jan 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49193/

nodejs-github-bot commented Jan 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49207/

nodejs-github-bot commented Jan 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49209/

nodejs-github-bot commented Jan 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49211/

theanarkh added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 28, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 28, 2023
nodejs-github-bot merged commit 4076418 into nodejs:main Jan 28, 2023

nodejs-github-bot commented Jan 28, 2023

Copy link
Copy Markdown
Collaborator

Landed in 4076418

ruyadorno pushed a commit that referenced this pull request Feb 1, 2023
test: fix logInTimeout is not function
d5d837b 
PR-URL: #46348
Refs: #44390
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
ruyadorno mentioned this pull request Feb 1, 2023
Merged
juanarbol mentioned this pull request Mar 3, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
test: fix logInTimeout is not function
31fdd93 
PR-URL: #46348
Refs: #44390
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
test: fix logInTimeout is not function
ed3fb52 
PR-URL: #46348
Refs: #44390
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
anonrig anonrig approved these changes

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL