src: fix c++ exception on bad command line arg - #46290
Merged
nodejs-github-bot merged 1 commit intoJan 22, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Replace stoull() with strtoull(). The former throws an exception when the input is malformed, the latter doesn't. Fixes: nodejs#46223
Copy link
Copy Markdown
Member
|
Apologies if my remark doesn't make sense, but don't we explicitly disable C++ exceptions in the build? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Yes, but. -fno-exceptions means our code can't throw. Third-party code like libstdc++ still can (and does.) |
Sorry, something went wrong.
cjihrig
approved these changes
Jan 20, 2023
RaisinTen
approved these changes
Jan 20, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
tniessen
approved these changes
Jan 21, 2023
jasnell
approved these changes
Jan 21, 2023
ruyadorno
pushed a commit
that referenced
this pull request
Feb 1, 2023
Replace stoull() with strtoull(). The former throws an exception when the input is malformed, the latter doesn't. Fixes: #46223 PR-URL: #46290 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Mar 3, 2023
Replace stoull() with strtoull(). The former throws an exception when the input is malformed, the latter doesn't. Fixes: #46223 PR-URL: #46290 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Mar 5, 2023
Replace stoull() with strtoull(). The former throws an exception when the input is malformed, the latter doesn't. Fixes: #46223 PR-URL: #46290 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace stoull() with strtoull(). The former throws an exception when the input is malformed, the latter doesn't.
Fixes: #46223