Review requested:

• @nodejs/gyp

CI: https://ci.nodejs.org/job/node-test-pull-request/48237/

CI: https://ci.nodejs.org/job/node-test-pull-request/48574/

CI: https://ci.nodejs.org/job/node-test-pull-request/49223/

@mohd-akram The cpp linting is failed, see https://github.com/nodejs/node/actions/runs/3481978405/jobs/5825655808

I saw that, but it's for existing lines unrelated to the PR so I didn't change it. I'll fix it?

I saw that, but it's for existing lines unrelated to the PR so I didn't change it. I'll fix it?

That will be good. Looks the task only trigger on changed files.

CI: https://ci.nodejs.org/job/node-test-pull-request/49243/

CI: https://ci.nodejs.org/job/node-test-pull-request/49249/

Landed in 3abd559

@mohd-akram Thx for the contribution :)

hi @gengjiawen just want to make sure this makes sense as a notable-change since at first glance it looked to me like it's only adding a missing symbol on a platform-specific version (windows).

Could you elaborate a bit more on why do you want to highlight that as a notable change for Node.js end-users? (Also if you do so, it's a good chance to put together a small write-up so that it shows up more than just the commit message in the changelog, similar to the ESM write-up in #46455) 😊 thanks in advance!

Could you elaborate a bit more on why do you want to highlight that as a notable change for Node.js end-users?

Windows users can use more native functions in openssl like unix user.

As a side effect, the binary may have become a fair bit bigger on Windows.

thank you @gengjiawen, unfortunately I had already closed the changelog and ran the release job yesterday in order to promote the builds today. sorry about that!

Adding the raw commit message in change won't hurt much. But missing it will make lots of people miss it.
I hope next time this will not be a blocker or not rushing release.