FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: s390x zlib test case fixes by AdamMajer · Pull Request #46367 · nodejs/node · GitHub

/ node Public

test: s390x zlib test case fixes - #46367

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
AdamMajer:s390
Jan 28, 2023
ConversationCommits (1)ChecksFiles changed
Merged

test: s390x zlib test case fixes#46367
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
AdamMajer:s390

Conversation

AdamMajer commented Jan 26, 2023

Copy link
Copy Markdown
Contributor

This is similar to #44117 and addresses the indeterminate nature of the hardware accelerated compression.

The fix looks kind of ugly but I wanted to keep the asserts the same.

test: s390x zlib test case fixes
25d69a6 
This is similar to nodejs#44117 and
addresses the indeterminate nature of the hardware accelerated
compression.
nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 26, 2023
lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 26, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 26, 2023

nodejs-github-bot commented Jan 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49199/

nodejs-github-bot commented Jan 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49215/

mhdawson approved these changes Jan 27, 2023
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 28, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 28, 2023
nodejs-github-bot merged commit 223dc69 into nodejs:main Jan 28, 2023

nodejs-github-bot commented Jan 28, 2023

Copy link
Copy Markdown
Collaborator

Landed in 223dc69

ruyadorno pushed a commit that referenced this pull request Feb 1, 2023
test: s390x zlib test case fixes
7385edc 
This is similar to #44117 and
addresses the indeterminate nature of the hardware accelerated
compression.

PR-URL: #46367
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
ruyadorno mentioned this pull request Feb 1, 2023
Merged
juanarbol mentioned this pull request Mar 3, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
test: s390x zlib test case fixes
2ff230a 
This is similar to #44117 and
addresses the indeterminate nature of the hardware accelerated
compression.

PR-URL: #46367
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
test: s390x zlib test case fixes
9d40aef 
This is similar to #44117 and
addresses the indeterminate nature of the hardware accelerated
compression.

PR-URL: #46367
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
+1 more reviewer
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL