FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: update undici to 5.16.0 by nodejs-github-bot · Pull Request #46213 · nodejs/node · GitHub

/ node Public

deps: update undici to 5.16.0 - #46213

Merged
nodejs-github-bot merged 3 commits into
mainfrom
actions/tools-update-undici
Jan 27, 2023
ConversationCommits (3)ChecksFiles changed
Merged

deps: update undici to 5.16.0#46213
nodejs-github-bot merged 3 commits into
mainfrom
actions/tools-update-undici

Conversation

nodejs-github-bot commented Jan 14, 2023

Copy link
Copy Markdown
Collaborator

This is an automated update of undici to 5.15.0.

nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Jan 14, 2023

debadree25 commented Jan 15, 2023

Copy link
Copy Markdown
Contributor

Could we rerun this workflow, in reference to #46217

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 19, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 19, 2023

nodejs-github-bot commented Jan 19, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/49065/

richardlau added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jan 19, 2023

richardlau commented Jan 19, 2023

Copy link
Copy Markdown
Member

This has relevant looking test failures for the withoutssl build. @nodejs/undici

ronag commented Jan 19, 2023

Copy link
Copy Markdown
Member

This has relevant looking test failures for the withoutssl build. @nodejs/undici

Where do I see those?

richardlau commented Jan 19, 2023

Copy link
Copy Markdown
Member

https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_withoutssl_x64/35531/consoleFull

Here's the first few failures:

09:17:10 python3 ./configure --verbose  --without-ssl
...
09:20:58 not ok 949 parallel/test-fetch
09:20:58   ---
09:20:58   duration_ms: 0.192
09:20:58   severity: fail
09:20:58   exitcode: 1
09:20:58   stack: |-
09:20:58     node:internal/errors:490
09:20:58         ErrorCaptureStackTrace(err);
09:20:58         ^
09:20:58     
09:20:58     Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto support
09:20:58         at new NodeError (node:internal/errors:399:5)
09:20:58         at assertCrypto (node:internal/util:171:11)
09:20:58         at node:crypto:36:1
09:20:58         at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/loaders:333:7)
09:20:58         at requireBuiltin (node:internal/bootstrap/loaders:364:14)
09:20:58         at requireWithFallbackInDeps (node:internal/bootstrap/loaders:373:10)
09:20:58         at lib/websocket/connection.js (node:internal/deps/undici/undici:14216:39)
09:20:58         at __require (node:internal/deps/undici/undici:4:50)
09:20:58         at lib/websocket/websocket.js (node:internal/deps/undici/undici:14394:44)
09:20:58         at __require (node:internal/deps/undici/undici:4:50) {
09:20:58       code: 'ERR_NO_CRYPTO'
09:20:58     }
09:20:58     
09:20:58     Node.js v20.0.0-pre
09:20:58   ...
...
09:22:04 not ok 1472 parallel/test-http-response-setheaders
09:22:04   ---
09:22:04   duration_ms: 0.176
09:22:04   severity: fail
09:22:04   exitcode: 1
09:22:04   stack: |-
09:22:04     node:internal/util:171
09:22:04         throw new ERR_NO_CRYPTO();
09:22:04         ^
09:22:04     
09:22:04     Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto support
09:22:04         at new NodeError (node:internal/errors:399:5)
09:22:04         at assertCrypto (node:internal/util:171:11)
09:22:04         at node:crypto:36:1
09:22:04         at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/loaders:333:7)
09:22:04         at requireBuiltin (node:internal/bootstrap/loaders:364:14)
09:22:04         at requireWithFallbackInDeps (node:internal/bootstrap/loaders:373:10)
09:22:04         at lib/websocket/connection.js (node:internal/deps/undici/undici:14216:39)
09:22:04         at __require (node:internal/deps/undici/undici:4:50)
09:22:04         at lib/websocket/websocket.js (node:internal/deps/undici/undici:14394:44)
09:22:04         at __require (node:internal/deps/undici/undici:4:50) {
09:22:04       code: 'ERR_NO_CRYPTO'
09:22:04     }
09:22:04     
09:22:04     Node.js v20.0.0-pre
09:22:04   ...
...
09:23:55 not ok 3122 parallel/test-wasm-web-api
09:23:55   ---
09:23:55   duration_ms: 0.219
09:23:55   severity: fail
09:23:55   exitcode: 1
09:23:55   stack: |-
09:23:55     node:internal/process/promises:289
09:23:55                 triggerUncaughtException(err, true /* fromPromise */);
09:23:55                 ^
09:23:55     
09:23:55     AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
09:23:55     + actual - expected
09:23:55     
09:23:55       Comparison {
09:23:55     +   code: 'ERR_NO_CRYPTO',
09:23:55     +   message: 'Node.js is not compiled with OpenSSL crypto support',
09:23:55     +   name: 'Error'
09:23:55     -   code: 'ERR_INVALID_ARG_TYPE',
09:23:55     -   message: /^The "source" argument .*$/,
09:23:55     -   name: 'TypeError'
09:23:55       }
09:23:55         at async Promise.all (index 1)
09:23:55         at async /home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-wasm-web-api.js:73:5 {
09:23:55       generatedMessage: true,
09:23:55       code: 'ERR_ASSERTION',
09:23:55       actual: Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto support
09:23:55           at new NodeError (node:internal/errors:399:5)
09:23:55           at assertCrypto (node:internal/util:171:11)
09:23:55           at node:crypto:36:1
09:23:55           at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/loaders:333:7)
09:23:55           at requireBuiltin (node:internal/bootstrap/loaders:364:14)
09:23:55           at requireWithFallbackInDeps (node:internal/bootstrap/loaders:373:10)
09:23:55           at lib/websocket/connection.js (node:internal/deps/undici/undici:14216:39)
09:23:55           at __require (node:internal/deps/undici/undici:4:50)
09:23:55           at lib/websocket/websocket.js (node:internal/deps/undici/undici:14394:44)
09:23:55           at __require (node:internal/deps/undici/undici:4:50) {
09:23:55         code: 'ERR_NO_CRYPTO'
09:23:55       },
09:23:55       expected: {
09:23:55         name: 'TypeError',
09:23:55         code: 'ERR_INVALID_ARG_TYPE',
09:23:55         message: /^The "source" argument .*$/
09:23:55       },
09:23:55       operator: 'rejects'
09:23:55     }
09:23:55     
09:23:55     Node.js v20.0.0-pre
09:23:55   ...
...
09:26:00 Failed tests:
09:26:00 out/Release/node /home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-fetch.mjs
09:26:00 out/Release/node /home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-http-response-setheaders.js
09:26:00 out/Release/node /home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-wasm-web-api.js
09:26:00 out/Release/node /home/iojs/build/workspace/node-test-commit-linux-containered/test/wpt/test-structured-clone.js
09:26:00 out/Release/node /home/iojs/build/workspace/node-test-commit-linux-containered/test/wpt/test-url.js
09:26:00 out/Release/node /home/iojs/build/workspace/node-test-commit-linux-containered/test/wpt/test-wasm-webapi.js

mcollina commented Jan 19, 2023

Copy link
Copy Markdown
Member

@KhafraDev I think we should avoid loading WebSocket if there is no crypto, and definitely do not crash.

This was referenced Jan 20, 2023
Open
Open
Open
richardlau removed the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jan 22, 2023
github-actions Bot mentioned this pull request Jan 23, 2023
Open
13 tasks
aduh95 force-pushed the actions/tools-update-undici branch from 323d837 to 16da87b Compare January 23, 2023 08:55
aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2023

nodejs-github-bot commented Jan 23, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/49137/

richardlau added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Jan 23, 2023
This was referenced Jan 24, 2023
Open
Open
mcollina changed the title deps: update undici to 5.15.0 deps: update undici to 5.16.0 Jan 26, 2023
mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 26, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 26, 2023
richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 27, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 27, 2023

nodejs-github-bot commented Jan 27, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/49204/

mcollina approved these changes Jan 27, 2023
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

mcollina added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Jan 27, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 27, 2023
nodejs-github-bot merged commit 19623e3 into main Jan 27, 2023
nodejs-github-bot deleted the actions/tools-update-undici branch January 27, 2023 13:50

nodejs-github-bot commented Jan 27, 2023

Copy link
Copy Markdown
Collaborator Author

Landed in 19623e3

richardlau commented Jan 27, 2023

Copy link
Copy Markdown
Member

@mcollina FYI Unfortunately squashing the commits using the commit queue has given the squashed commit the title from the first commit: 19623e3
"deps: update undici to 5.15.0" which is going to be confusing in the changelogs.

The commit queue works this way because the more common squash flow is that the follow up commits being squashed are fix ups.

ruyadorno pushed a commit that referenced this pull request Feb 1, 2023
deps: update undici to 5.15.0
9c2f3ce 
PR-URL: #46213
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
ruyadorno mentioned this pull request Feb 1, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
anonrig anonrig approved these changes
richardlau richardlau approved these changes

Assignees

No one assigned

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL