FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test_runner: make built in reporters internal by cjihrig · Pull Request #46092 · nodejs/node · GitHub

/ node Public

test_runner: make built in reporters internal - #46092

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
cjihrig:reporters
Jan 6, 2023
ConversationCommits (1)ChecksFiles changed
Merged

test_runner: make built in reporters internal#46092
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
cjihrig:reporters

Conversation

cjihrig commented Jan 4, 2023

Copy link
Copy Markdown
Contributor

This commit updates the test runner to make the built in test reporters internal modules.

Fixes: #46061 (comment)

test_runner: make built in reporters internal
c1a4ccb 
This commit updates the test runner to make the built in test
reporters internal modules.

nodejs-github-bot commented Jan 4, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 4, 2023
cjihrig mentioned this pull request Jan 4, 2023
Merged
3 tasks
aduh95 added experimental Issues and PRs related to experimental features. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 4, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 4, 2023

nodejs-github-bot commented Jan 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48850/

MoLow approved these changes Jan 4, 2023
View reviewed changes

MoLow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for fixing!

MoLow added the test_runner Issues and PRs related to the test runner subsystem. label Jan 4, 2023
cjihrig added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Jan 5, 2023
jaydenseric mentioned this pull request Jan 5, 2023
Merged
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 6, 2023
nodejs-github-bot merged commit 4788c0d into nodejs:main Jan 6, 2023

nodejs-github-bot commented Jan 6, 2023

Copy link
Copy Markdown
Collaborator

Landed in 4788c0d

cjihrig deleted the reporters branch January 6, 2023 19:55

RafaelGSS commented Jan 17, 2023

Copy link
Copy Markdown
Member

Hi @cjihrig! It didn't land cleanly on v19.x-staging, I'm pretty sure that's due to the fact of dependents' PRs are tagged with dont-land-on-vX. I'll skip this commit on v19.5.0 proposal, but when all the fixes were addressed you can ping me, I can include it in the v19.5.0 proposal.

In any case I'm adding the label backport-requested.

bricss mentioned this pull request Jan 22, 2023
Merged

juanarbol commented Jan 25, 2023

Copy link
Copy Markdown
Member

This is not landing cleanly in v18.x 💔

cjihrig commented Jan 25, 2023

Copy link
Copy Markdown
Contributor Author

This (and probably most other test runner commits) cannot be backported until #45712 is backported.

MoLow mentioned this pull request Jan 26, 2023
Closed
MoLow pushed a commit to MoLow/node that referenced this pull request Jan 26, 2023
test_runner: make built in reporters internal
0e0541c 
This commit updates the test runner to make the built in test
reporters internal modules.

PR-URL: nodejs#46092
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
MoLow mentioned this pull request Jan 26, 2023
Closed
MoLow pushed a commit to MoLow/node that referenced this pull request Jan 26, 2023
test_runner: make built in reporters internal
e304cc5 
This commit updates the test runner to make the built in test
reporters internal modules.

PR-URL: nodejs#46092
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
ruyadorno pushed a commit that referenced this pull request Jan 31, 2023
test_runner: make built in reporters internal
8b473af 
This commit updates the test runner to make the built in test
reporters internal modules.

Backport-PR-URL: #46361
PR-URL: #46092
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
ruyadorno mentioned this pull request Feb 1, 2023
Merged
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 6, 2023
fix: make built in reporters internal
3f28f7d 
This commit updates the test runner to make the built in test
reporters internal modules.

PR-URL: nodejs/node#46092
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
(cherry picked from commit 4788c0d2a02a2e7c7088c6f39d9f13a4209ba863)
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 7, 2023
fix: make built in reporters internal
0743c23 
This commit updates the test runner to make the built in test
reporters internal modules.

PR-URL: nodejs/node#46092
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
(cherry picked from commit 4788c0d2a02a2e7c7088c6f39d9f13a4209ba863)
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 7, 2023
fix: make built in reporters internal
c24bcb9 
This commit updates the test runner to make the built in test
reporters internal modules.

PR-URL: nodejs/node#46092
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
(cherry picked from commit 4788c0d2a02a2e7c7088c6f39d9f13a4209ba863)
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 7, 2023
fix: make built in reporters internal
e50df0e 
This commit updates the test runner to make the built in test
reporters internal modules.

PR-URL: nodejs/node#46092
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
(cherry picked from commit 4788c0d2a02a2e7c7088c6f39d9f13a4209ba863)
MoLow pushed a commit to nodejs/node-core-test that referenced this pull request Feb 8, 2023
fix: make built in reporters internal
b6177a4 
This commit updates the test runner to make the built in test
reporters internal modules.

PR-URL: nodejs/node#46092
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
(cherry picked from commit 4788c0d2a02a2e7c7088c6f39d9f13a4209ba863)
MoLow pushed a commit to MoLow/node that referenced this pull request Feb 25, 2023
test_runner: make built in reporters internal
6d9ec6c 
This commit updates the test runner to make the built in test
reporters internal modules.

PR-URL: nodejs#46092
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
MoLow mentioned this pull request Mar 3, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
test_runner: make built in reporters internal
a9c3678 
This commit updates the test runner to make the built in test
reporters internal modules.

PR-URL: #46092
Backport-PR-URL: #46839
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
test_runner: make built in reporters internal
0d999e3 
This commit updates the test runner to make the built in test
reporters internal modules.

PR-URL: #46092
Backport-PR-URL: #46839
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ljharb ljharb approved these changes
tniessen tniessen approved these changes
MoLow MoLow approved these changes
aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. experimental Issues and PRs related to experimental features. lib / src Issues and PRs related to general changes in the lib or src directory. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL