FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

module: move test reporter loading by GeoffreyBooth · Pull Request #45923 · nodejs/node · GitHub

/ node Public

module: move test reporter loading - #45923

Merged
nodejs-github-bot merged 9 commits into
nodejs:mainfrom
GeoffreyBooth:move-test-reporter-loading
Dec 22, 2022
ConversationCommits (9)ChecksFiles changed
Merged

module: move test reporter loading#45923
nodejs-github-bot merged 9 commits into
nodejs:mainfrom
GeoffreyBooth:move-test-reporter-loading

Conversation

GeoffreyBooth commented Dec 20, 2022

Copy link
Copy Markdown
Member

This PR resolves my concerns with #45712 (comment), without making any changes to --test-reporter or breaking any tests. Essentially, it moves the module loading that --test-reporter wants to do to happen inside the test_runner section of the codebase, keeping it separate; and it loads all test reporters through the ESM loader, following our current design for module loading features and preserving support for things like loaders applying to test reporters.

All changes in this PR for files under lib/internal/modules are just reverting the changes to those files that landed in #45712.

cc @nodejs/test_runner @nodejs/loaders @nodejs/modules

GeoffreyBooth added module Issues and PRs related to the module subsystem. esm Issues and PRs related to the ECMAScript Modules implementation. loaders Issues and PRs related to ES module loaders test_runner Issues and PRs related to the test runner subsystem. labels Dec 20, 2022
GeoffreyBooth requested a review from MoLow December 20, 2022 18:15

nodejs-github-bot commented Dec 20, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/modules

nodejs-github-bot added dont-land-on-v14.x needs-ci PRs that need a full CI run. labels Dec 20, 2022
GeoffreyBooth mentioned this pull request Dec 20, 2022
Merged
3 tasks
GeoffreyBooth force-pushed the move-test-reporter-loading branch from 722fb95 to 2751e68 Compare December 20, 2022 18:20

This comment was marked as outdated.

Sign in to view
GeoffreyBooth mentioned this pull request Dec 20, 2022
Closed
cjihrig reviewed Dec 20, 2022
View reviewed changes
Comment thread doc/api/test.md Outdated
MoLow approved these changes Dec 20, 2022
View reviewed changes

MoLow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

thanks, @GeoffreyBooth looks really good. indeed a ping on the original PR would have resolved this entire discussion!

GeoffreyBooth commented Dec 20, 2022

Copy link
Copy Markdown
Member Author

thanks, @GeoffreyBooth looks really good. indeed a ping on the original PR would have resolved this entire discussion!

Agreed. Sorry if I came across as a bit annoyed. At first I thought you’d introduced a merge conflict with #45869 which I’ve been trying to land for days, but fortunately you hadn’t 😄

MoLow commented Dec 20, 2022

Copy link
Copy Markdown
Member

@GeoffreyBooth if it is ok with you can we cherry-pick / push this commit to this PR? 9bb6248

GeoffreyBooth commented Dec 20, 2022

Copy link
Copy Markdown
Member Author

@GeoffreyBooth if it is ok with you can we cherry-pick / push this commit to this PR? 9bb6248

I guess, but I kind of feel like this should be on its own as its mostly a “revert” PR which are usually isolated. Also this should hopefully be able to land immediately, which would then allow #45712 to go out in a release; whereas if there are any delays in whatever you want to cherry-pick this onto, then this revert fix and #45712’s release also get delayed.

MoLow commented Dec 20, 2022

Copy link
Copy Markdown
Member

Ok Il ship it in a follow-up PR then

aduh95 reviewed Dec 20, 2022
View reviewed changes
Comment thread lib/internal/test_runner/utils.js Outdated

MoLow commented Dec 20, 2022

Copy link
Copy Markdown
Member

Discussed with @GeoffreyBooth in slack, and pushed tests + lint fix

MoLow added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Dec 20, 2022
JakobJingleheimer approved these changes Dec 20, 2022
View reviewed changes

JakobJingleheimer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🙌

GeoffreyBooth force-pushed the move-test-reporter-loading branch 2 times, most recently from d896dce to 021ad3d Compare December 20, 2022 23:51

nodejs-github-bot commented Dec 20, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48658/

GeoffreyBooth added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 21, 2022
aduh95 reviewed Dec 21, 2022
View reviewed changes
Comment thread lib/internal/test_runner/utils.js Outdated
MoLow mentioned this pull request Jan 26, 2023
Closed
MoLow pushed a commit to MoLow/node that referenced this pull request Jan 26, 2023
module: move test reporter loading
249f764 
Move the logic for handling --test-reporter out of the
general module loader and into the test_runner subsystem.

PR-URL: nodejs#45923
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow mentioned this pull request Jan 26, 2023
Closed
MoLow pushed a commit to MoLow/node that referenced this pull request Jan 26, 2023
module: move test reporter loading
7ad6b73 
Move the logic for handling --test-reporter out of the
general module loader and into the test_runner subsystem.

PR-URL: nodejs#45923
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
ruyadorno pushed a commit that referenced this pull request Jan 31, 2023
module: move test reporter loading
3a3a6d8 
Move the logic for handling --test-reporter out of the
general module loader and into the test_runner subsystem.

Backport-PR-URL: #46361
PR-URL: #45923
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
ruyadorno mentioned this pull request Feb 1, 2023
Merged
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 6, 2023
fix: move test reporter loading
0556bc7 
Move the logic for handling --test-reporter out of the
general module loader and into the test_runner subsystem.

PR-URL: nodejs/node#45923
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
(cherry picked from commit 12c0571c8fece32d274eaf0ae197c0eb1948fe11)
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 7, 2023
fix: move test reporter loading
9ff5db7 
Move the logic for handling --test-reporter out of the
general module loader and into the test_runner subsystem.

PR-URL: nodejs/node#45923
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
(cherry picked from commit 12c0571c8fece32d274eaf0ae197c0eb1948fe11)
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 7, 2023
fix: move test reporter loading
5d12932 
Move the logic for handling --test-reporter out of the
general module loader and into the test_runner subsystem.

PR-URL: nodejs/node#45923
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
(cherry picked from commit 12c0571c8fece32d274eaf0ae197c0eb1948fe11)
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 7, 2023
fix: move test reporter loading
57de87d 
Move the logic for handling --test-reporter out of the
general module loader and into the test_runner subsystem.

PR-URL: nodejs/node#45923
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
(cherry picked from commit 12c0571c8fece32d274eaf0ae197c0eb1948fe11)
MoLow pushed a commit to nodejs/node-core-test that referenced this pull request Feb 8, 2023
fix: move test reporter loading
a5e0e9e 
Move the logic for handling --test-reporter out of the
general module loader and into the test_runner subsystem.

PR-URL: nodejs/node#45923
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
(cherry picked from commit 12c0571c8fece32d274eaf0ae197c0eb1948fe11)
MoLow pushed a commit to MoLow/node that referenced this pull request Feb 25, 2023
module: move test reporter loading
a34809a 
Move the logic for handling --test-reporter out of the
general module loader and into the test_runner subsystem.

PR-URL: nodejs#45923
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
module: move test reporter loading
4e60e56 
Move the logic for handling --test-reporter out of the
general module loader and into the test_runner subsystem.

PR-URL: #45923
Backport-PR-URL: #46839
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol mentioned this pull request Mar 3, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
module: move test reporter loading
403df21 
Move the logic for handling --test-reporter out of the
general module loader and into the test_runner subsystem.

PR-URL: #45923
Backport-PR-URL: #46839
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
octo-sts Bot mentioned this pull request Dec 12, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cjihrig cjihrig approved these changes
benjamingr benjamingr approved these changes
JakobJingleheimer JakobJingleheimer approved these changes
MoLow MoLow approved these changes
aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. esm Issues and PRs related to the ECMAScript Modules implementation. loaders Issues and PRs related to ES module loaders module Issues and PRs related to the module subsystem. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL