doc: correct the sed command for macOS in release process docs - #46397
Merged
nodejs-github-bot merged 1 commit intoJan 31, 2023
Merged
doc: correct the sed command for macOS in release process docs#46397nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
sanqro
reviewed
Jan 28, 2023
sanqro
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
Your contribution seems good. Please specify your writing on line 431
Sorry, something went wrong.
Comment thread
doc/contributing/releases.md
Outdated
juanarbol
force-pushed
the
juan/sed-command-update
branch
from
3ed70b7 to
0f1ef61
Compare
January 31, 2023 16:48
aduh95
approved these changes
Jan 31, 2023
RafaelGSS
approved these changes
Jan 31, 2023
ruyadorno
pushed a commit
that referenced
this pull request
Feb 1, 2023
PR-URL: #46397 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Merged
Merged
juanarbol
added a commit
that referenced
this pull request
Mar 3, 2023
PR-URL: #46397 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
juanarbol
added a commit
that referenced
this pull request
Mar 5, 2023
PR-URL: #46397 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documented sed command was failing in my machine during a release proposal preparation.
sed: 1: "MD-FILE": extra characters at the end of d commandYou could see this https://stackoverflow.com/a/62309999 as a ref to the issue of the sed command in macOS which makes the sed command works again in macOS