FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

benchmark: introduce benchmark combination filtering by mscdex · Pull Request #45735 · nodejs/node · GitHub

/ node Public

benchmark: introduce benchmark combination filtering - #45735

Closed
mscdex wants to merge 2 commits into
nodejs:mainfrom
mscdex:benchmark-filter-combinations
ConversationCommits (2)ChecksFiles changed
Closed

benchmark: introduce benchmark combination filtering#45735
mscdex wants to merge 2 commits into
nodejs:mainfrom
mscdex:benchmark-filter-combinations

Conversation

mscdex commented Dec 4, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

This should help avoid redundant/unnecessary benchmark runs. For this PR, I've only included changes for Buffer benchmarks that would benefit from this.

If this is acceptable, the other benchmark categories would need to be reviewed and modified where appropriate as well, probably in additional PRs?

mscdex added the benchmark Issues and PRs related to the benchmark subsystem. label Dec 4, 2022

nodejs-github-bot commented Dec 4, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

This comment was marked as outdated.

Sign in to view
mscdex force-pushed the benchmark-filter-combinations branch from 3c160ad to 3b7423b Compare December 4, 2022 21:04

nodejs-github-bot commented Dec 4, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48294/

mcollina approved these changes Dec 4, 2022
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

daeyeon reviewed Dec 5, 2022
View reviewed changes
Comment thread benchmark/buffers/buffer-copy.js
This was referenced Dec 7, 2022
Open
Open
This was referenced Dec 9, 2022
Open
Open

nodejs-github-bot commented Jan 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49052/

github-actions Bot mentioned this pull request Jan 19, 2023
Open
14 tasks

nodejs-github-bot commented Jan 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49069/

This was referenced Jan 20, 2023
Open
Open
Open

nodejs-github-bot commented Jan 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49126/

lpinca added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Jan 22, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 22, 2023

nodejs-github-bot commented Jan 22, 2023

Copy link
Copy Markdown
Collaborator

Landed in cc18fd9...863a416

nodejs-github-bot pushed a commit that referenced this pull request Jan 22, 2023
benchmark: introduce benchmark combination filtering
1a8d340 
PR-URL: #45735
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Jan 22, 2023
benchmark: remove buffer benchmarks redundancy
863a416 
PR-URL: #45735
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
mscdex deleted the benchmark-filter-combinations branch January 22, 2023 08:34
This was referenced Jan 23, 2023
Open
Open
Open
ruyadorno pushed a commit that referenced this pull request Feb 1, 2023
benchmark: introduce benchmark combination filtering
6186b3e 
PR-URL: #45735
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
ruyadorno pushed a commit that referenced this pull request Feb 1, 2023
benchmark: remove buffer benchmarks redundancy
f318a85 
PR-URL: #45735
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
ruyadorno mentioned this pull request Feb 1, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
benchmark: introduce benchmark combination filtering
bd16dc4 
PR-URL: #45735
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
benchmark: remove buffer benchmarks redundancy
375f2b8 
PR-URL: #45735
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
juanarbol mentioned this pull request Mar 3, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
benchmark: introduce benchmark combination filtering
6468f30 
PR-URL: #45735
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
benchmark: remove buffer benchmarks redundancy
d0b9be2 
PR-URL: #45735
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
lpinca lpinca approved these changes
anonrig anonrig approved these changes
daeyeon daeyeon approved these changes
BridgeAR BridgeAR approved these changes
RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

benchmark Issues and PRs related to the benchmark subsystem. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL