Commit fb7bee2
src: fix c++ exception on bad command line arg
Replace stoull() with strtoull(). The former throws an exception when
the input is malformed, the latter doesn't.
Fixes: #46223
PR-URL: #46290
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 940484b commit fb7bee2
2 files changed
Lines changed: 4 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -444,7 +444,8 @@ void OptionsParser<Options>::Parse( | |||
| 444 | 444 | *Lookup<int64_t>(info.field, options) = std::atoll(value.c_str()); | |
| 445 | 445 | break; | |
| 446 | 446 | case kUInteger: | |
| 447 | - *Lookup<uint64_t>(info.field, options) = std::stoull(value); | ||
| 447 | + *Lookup<uint64_t>(info.field, options) = | ||
| 448 | + std::strtoull(value.c_str(), nullptr, 10); | ||
| 448 | 449 | break; | |
| 449 | 450 | case kString: | |
| 450 | 451 | *Lookup<std::string>(info.field, options) = value; | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -58,11 +58,11 @@ const { | |||
| 58 | 58 | } | |
| 59 | 59 | ||
| 60 | 60 | // --cpu-prof-interval without --cpu-prof | |
| 61 | - { | ||
| 61 | + for (const arg of [kCpuProfInterval, 'crashme']) { | ||
| 62 | 62 | tmpdir.refresh(); | |
| 63 | 63 | const output = spawnSync(process.execPath, [ | |
| 64 | 64 | '--cpu-prof-interval', | |
| 65 | - kCpuProfInterval, | ||
| 65 | + arg, | ||
| 66 | 66 | fixtures.path('workload', 'fibonacci.js'), | |
| 67 | 67 | ], { | |
| 68 | 68 | cwd: tmpdir.path, | |
0 commit comments