FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: replace unreachable code with static_assert by tniessen · Pull Request #46250 · nodejs/node · GitHub

/ node Public

src: replace unreachable code with static_assert - #46250

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:src-crypto-secretkeygentraits-staticassert
Jan 21, 2023
ConversationCommits (1)ChecksFiles changed
Merged

src: replace unreachable code with static_assert#46250
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:src-crypto-secretkeygentraits-staticassert

Conversation

tniessen commented Jan 18, 2023

Copy link
Copy Markdown
Member

This function divides an unsigned 32-bit integer by 8, effectively right-shifting it by three bits, so the result must be less than INT_MAX.

Refs: #46209

nodejs-github-bot commented Jan 18, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Jan 18, 2023
src: replace unreachable code with static_assert
2eb372d 
This function divides an unsigned 32-bit integer by 8, effectively
right-shifting it by three bits, so the result must be less than
INT_MAX.

Refs: nodejs#46209
tniessen force-pushed the src-crypto-secretkeygentraits-staticassert branch from 632c5b4 to 2eb372d Compare January 18, 2023 12:37
addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 18, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 18, 2023

This comment was marked as outdated.

Sign in to view
tniessen added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 18, 2023

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented Jan 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49056/

This was referenced Jan 19, 2023
Open
Open
Open
lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 21, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 21, 2023
nodejs-github-bot merged commit 5ccf4ef into nodejs:main Jan 21, 2023

nodejs-github-bot commented Jan 21, 2023

Copy link
Copy Markdown
Collaborator

Landed in 5ccf4ef

This was referenced Jan 22, 2023
Open
Open
Open
ruyadorno pushed a commit that referenced this pull request Feb 1, 2023
src: replace unreachable code with static_assert
8307a4b 
This function divides an unsigned 32-bit integer by 8, effectively
right-shifting it by three bits, so the result must be less than
INT_MAX.

Refs: #46209
PR-URL: #46250
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
ruyadorno mentioned this pull request Feb 1, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
src: replace unreachable code with static_assert
9cd0a1d 
This function divides an unsigned 32-bit integer by 8, effectively
right-shifting it by three bits, so the result must be less than
INT_MAX.

Refs: #46209
PR-URL: #46250
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
juanarbol mentioned this pull request Mar 3, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
src: replace unreachable code with static_assert
cde3755 
This function divides an unsigned 32-bit integer by 8, effectively
right-shifting it by three bits, so the result must be less than
INT_MAX.

Refs: #46209
PR-URL: #46250
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnoordhuis bnoordhuis approved these changes
addaleax addaleax approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL