lib: remove unnecessary ObjectGetValueSafe - #46335
Merged
nodejs-github-bot merged 1 commit intoJan 30, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
lpinca
approved these changes
Jan 24, 2023
cjihrig
approved these changes
Jan 24, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
approved these changes
Jan 24, 2023
12 tasks
bnoordhuis
approved these changes
Jan 25, 2023
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/46335 ✔ Done loading data for nodejs/node/pull/46335 ----------------------------------- PR info ------------------------------------ Title lib: remove unnecessary ObjectGetValueSafe (#46335) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch legendecas:source-maps/prototype -> nodejs:main Labels author ready, needs-ci Commits 1 - lib: remove unnecessary ObjectGetValueSafe Committers 1 - legendecas PR-URL: https://github.com/nodejs/node/pull/46335 Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig Reviewed-By: Antoine du Hamel Reviewed-By: Ben Noordhuis ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46335 Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig Reviewed-By: Antoine du Hamel Reviewed-By: Ben Noordhuis -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 24 Jan 2023 16:47:33 GMT ✔ Approvals: 4 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46335#pullrequestreview-1268151895 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/46335#pullrequestreview-1268161298 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/46335#pullrequestreview-1268312343 ✔ - Ben Noordhuis (@bnoordhuis): https://github.com/nodejs/node/pull/46335#pullrequestreview-1268980292 ✖ Last GitHub CI failed ℹ Last Full PR CI on 2023-01-24T19:34:55Z: https://ci.nodejs.org/job/node-test-pull-request/49156/ - Querying data for job/node-test-pull-request/49156/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4017292160 |
Sorry, something went wrong.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Jan 29, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
ruyadorno
pushed a commit
that referenced
this pull request
Feb 1, 2023
PR-URL: #46335 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Copy link
Copy Markdown
Member
|
Depends on #46225 and can not be landed -yet- in v18.x |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the comment #46225 (review).
The prototype pollution test should have been covered in https://github.com/nodejs/node/blob/main/test/parallel/test-worker-terminate-source-map.js