FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

v8: support gc profile by theanarkh · Pull Request #46255 · nodejs/node · GitHub

/ node Public

v8: support gc profile - #46255

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
theanarkh:support_gc_profile
Jan 25, 2023
ConversationCommits (1)ChecksFiles changed
Merged

v8: support gc profile#46255
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
theanarkh:support_gc_profile

Conversation

theanarkh commented Jan 18, 2023

Copy link
Copy Markdown
Contributor

support gc profile. the content is as follows.

{
  "version": 1,
  "startTime": 1674059033862,
  "statistics": [
    {
      "gcType": "Scavenge",
      "beforeGC": {
        "heapStatistics": {
          "totalHeapSize": 5005312,
          "totalHeapSizeExecutable": 524288,
          "totalPhysicalSize": 5226496,
          "totalAvailableSize": 4341325216,
          "totalGlobalHandlesSize": 8192,
          "usedGlobalHandlesSize": 2112,
          "usedHeapSize": 4883840,
          "heapSizeLimit": 4345298944,
          "mallocedMemory": 254128,
          "externalMemory": 225138,
          "peakMallocedMemory": 181760
        },
        "heapSpaceStatistics": [
          {
            "spaceName": "read_only_space",
            "spaceSize": 0,
            "spaceUsedSize": 0,
            "spaceAvailableSize": 0,
            "physicalSpaceSize": 0
          }
        ]
      },
      "cost": 1574.14,
      "afterGC": {
        "heapStatistics": {
          "totalHeapSize": 6053888,
          "totalHeapSizeExecutable": 524288,
          "totalPhysicalSize": 5500928,
          "totalAvailableSize": 4341101384,
          "totalGlobalHandlesSize": 8192,
          "usedGlobalHandlesSize": 2112,
          "usedHeapSize": 4059096,
          "heapSizeLimit": 4345298944,
          "mallocedMemory": 254128,
          "externalMemory": 225138,
          "peakMallocedMemory": 181760
        },
        "heapSpaceStatistics": [
          {
            "spaceName": "read_only_space",
            "spaceSize": 0,
            "spaceUsedSize": 0,
            "spaceAvailableSize": 0,
            "physicalSpaceSize": 0
          }
        ]
      }
    }
  ],
  "endtTime": 1674059036865
}
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 18, 2023
addaleax reviewed Jan 18, 2023
View reviewed changes
Comment thread src/node_v8.cc Outdated
theanarkh force-pushed the support_gc_profile branch 2 times, most recently from cbcd60d to 8a8e086 Compare January 18, 2023 17:57
anonrig reviewed Jan 18, 2023
View reviewed changes
Comment thread doc/api/v8.md Outdated
Comment thread lib/v8.js Outdated
Comment thread src/node_v8.cc Outdated
Comment thread src/node_v8.h Outdated
Comment thread src/node_v8.cc Outdated
theanarkh force-pushed the support_gc_profile branch 5 times, most recently from 4756504 to e57ab16 Compare January 19, 2023 06:47
addaleax approved these changes Jan 19, 2023
View reviewed changes
Comment thread src/node_v8.cc Outdated
addaleax added the semver-minor PRs that contain new features and should be released in the next minor version. label Jan 19, 2023
theanarkh force-pushed the support_gc_profile branch 2 times, most recently from ce8dfe7 to ca62c3b Compare January 19, 2023 13:55
VoltrexKeyva reviewed Jan 19, 2023
View reviewed changes
Comment thread doc/api/v8.md Outdated
Comment thread doc/api/v8.md Outdated
Comment thread lib/v8.js Outdated
Comment thread src/node_v8.cc Outdated
Comment thread src/node_v8.cc Outdated
Comment thread test/common/v8.js Outdated
Comment thread test/parallel/test-v8-take-gc-profile-exit-before-stop.js Outdated
Comment thread test/parallel/test-v8-take-gc-profile-in-worker.js Outdated
Comment thread test/parallel/test-v8-take-gc-profile.js Outdated
jasnell reviewed Jan 20, 2023
View reviewed changes
Comment thread doc/api/v8.md Outdated
jasnell reviewed Jan 20, 2023
View reviewed changes
Comment thread doc/api/v8.md Outdated
jasnell reviewed Jan 20, 2023
View reviewed changes
Comment thread doc/api/v8.md Outdated

jasnell commented Jan 20, 2023

Copy link
Copy Markdown
Member

The perf_hooks module already has a PerformanceEntry type for GC operations. I'm wondering if it would make more sense to add this additional detail to that existing API than to add an entirely new API.

theanarkh commented Jan 20, 2023

Copy link
Copy Markdown
Contributor Author

The perf_hooks module already has a PerformanceEntry type for GC operations. I'm wondering if it would make more sense to add this additional detail to that existing API than to add an entirely new API.

Every time a GC occurs, perf_hooks will create a new entry and call JS callback later, I'm not sure If this will cause performance problems when GC is frequent, so i think we can implement this in C++. And we can add more informations in this API in the furure, like process.report do, such as GC load.

Currently i think the user can implement GC profile in JS land by combine perf_hooks, v8.getHeapSpaceStatistics() , and v8.getHeapStatistics(). i also try to implement GC load by perf_hooks(nodejs-gc-load), but i am going to implement this in Node.js Core.

theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 21, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 21, 2023

nodejs-github-bot commented Jan 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49119/

theanarkh requested review from addaleax and jasnell January 22, 2023 04:42
theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 25, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 25, 2023

nodejs-github-bot commented Jan 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49159/

nodejs-github-bot commented Jan 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49165/

theanarkh added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 25, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 25, 2023
nodejs-github-bot merged commit 733ef4e into nodejs:main Jan 25, 2023

nodejs-github-bot commented Jan 25, 2023

Copy link
Copy Markdown
Collaborator

Landed in 733ef4e

ruyadorno pushed a commit that referenced this pull request Feb 1, 2023
v8: support gc profile
b4ac794 
PR-URL: #46255
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
ruyadorno mentioned this pull request Feb 1, 2023
Merged
ruyadorno added the notable-change PRs with changes that should be highlighted in changelogs. label Feb 1, 2023
ruyadorno added a commit that referenced this pull request Feb 1, 2023
2023-02-02, Version 19.6.0 (Current)
3ecd96f 
Notable changes:

buffer:
  * (SEMVER-MINOR) add isAscii method (Yagiz Nizipli) #46046
deps:
  * upgrade npm to 9.4.0 (npm team) #46353
esm:
  * leverage loaders when resolving subsequent loaders (Maël Nison) #43772
fs:
  * (SEMVER-MINOR) add statfs() functions (Colin Ihrig) #46358
src,lib:
  * (SEMVER-MINOR) add constrainedMemory API for process (theanarkh) #46218
test_runner:
  * (SEMVER-MINOR) add reporters (Moshe Atlow) #45712
v8:
  * (SEMVER-MINOR) support gc profile (theanarkh) #46255
vm:
  * (SEMVER-MINOR) expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320

PR-URL: #46455
ruyadorno added a commit that referenced this pull request Feb 2, 2023
2023-02-02, Version 19.6.0 (Current)
1579ff4 
Notable changes:

buffer:
  * (SEMVER-MINOR) add isAscii method (Yagiz Nizipli) #46046
deps:
  * upgrade npm to 9.4.0 (npm team) #46353
esm:
  * leverage loaders when resolving subsequent loaders (Maël Nison) #43772
fs:
  * (SEMVER-MINOR) add statfs() functions (Colin Ihrig) #46358
src,lib:
  * (SEMVER-MINOR) add constrainedMemory API for process (theanarkh) #46218
test_runner:
  * (SEMVER-MINOR) add reporters (Moshe Atlow) #45712
v8:
  * (SEMVER-MINOR) support gc profile (theanarkh) #46255
vm:
  * (SEMVER-MINOR) expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320

PR-URL: #46455
juanarbol mentioned this pull request Mar 3, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
v8: support gc profile
95d1f59 
PR-URL: #46255
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
juanarbol added a commit that referenced this pull request Mar 3, 2023
2023-03-07, Version 18.15.0 'Hydrogen' (LTS)
6859857 
Notable Changes:

buffer:
  * add isAscii method (Yagiz Nizipli) #46046
fs:
  * add statfs() functions (Colin Ihrig) #46358
src,lib:
  * add constrainedMemory API for process (theanarkh) #46218
v8:
  * support gc profile (theanarkh) #46255
vm:
  * expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320

PR-URL: #46920
juanarbol added a commit that referenced this pull request Mar 3, 2023
2023-03-07, Version 18.15.0 'Hydrogen' (LTS)
6110438 
Notable Changes:

buffer:
  * (SEMVER-MINOR) add isAscii method (Yagiz Nizipli) #46046
doc,lib,src,test:
  * rename --test-coverage (Colin Ihrig) #46017
fs:
  * (SEMVER-MINOR) add statfs() functions (Colin Ihrig) #46358
src,lib:
  * (SEMVER-MINOR) add constrainedMemory API for process (theanarkh) #46218
test_runner:
  * add initial code coverage support (Colin Ihrig) #46017
  * (SEMVER-MINOR) add reporters (Moshe Atlow) #45712
v8:
  * (SEMVER-MINOR) support gc profile (theanarkh) #46255
vm:
  * (SEMVER-MINOR) expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320

PR-URL: #46920
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
v8: support gc profile
02632b4 
PR-URL: #46255
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
juanarbol added a commit that referenced this pull request Mar 5, 2023
2023-03-07, Version 18.15.0 'Hydrogen' (LTS)
a94966f 
Notable changes:

buffer:
  * (SEMVER-MINOR) add isAscii method (Yagiz Nizipli) #46046
doc,lib,src,test:
  * rename --test-coverage (Colin Ihrig) #46017
fs:
  * (SEMVER-MINOR) add statfs() functions (Colin Ihrig) #46358
src,lib:
  * (SEMVER-MINOR) add constrainedMemory API for process (theanarkh) #46218
test_runner:
  * add initial code coverage support (Colin Ihrig) #46017
  * (SEMVER-MINOR) add reporters (Moshe Atlow) #45712
v8:
  * (SEMVER-MINOR) support gc profile (theanarkh) #46255
vm:
  * (SEMVER-MINOR) expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320

PR-URL: #46920
juanarbol added a commit that referenced this pull request Mar 7, 2023
2023-03-07, Version 18.15.0 'Hydrogen' (LTS)
3b0c047 
Notable changes:

buffer:
  * (SEMVER-MINOR) add isAscii method (Yagiz Nizipli) #46046
doc,lib,src,test:
  * rename --test-coverage (Colin Ihrig) #46017
fs:
  * (SEMVER-MINOR) add statfs() functions (Colin Ihrig) #46358
src,lib:
  * (SEMVER-MINOR) add constrainedMemory API for process (theanarkh) #46218
test_runner:
  * add initial code coverage support (Colin Ihrig) #46017
  * (SEMVER-MINOR) add reporters (Moshe Atlow) #45712
v8:
  * (SEMVER-MINOR) support gc profile (theanarkh) #46255
vm:
  * (SEMVER-MINOR) expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320

PR-URL: #46920
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anonrig anonrig left review comments
addaleax addaleax approved these changes
RafaelGSS RafaelGSS approved these changes
jasnell Awaiting requested review from jasnell
+2 more reviewers
VoltrexKeyva VoltrexKeyva left review comments
fhinkel fhinkel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL