FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v19.x backport] http: res set headers by marco-ippolito · Pull Request #46272 · nodejs/node · GitHub

/ node Public

[v19.x backport] http: res set headers - #46272

Closed
marco-ippolito wants to merge 2 commits into
nodejs:v19.x-stagingfrom
marco-ippolito:backport/set-header-backport
ConversationCommits (2)ChecksFiles changed
Closed

[v19.x backport] http: res set headers#46272
marco-ippolito wants to merge 2 commits into
nodejs:v19.x-stagingfrom
marco-ippolito:backport/set-header-backport

Conversation

marco-ippolito commented Jan 19, 2023

Copy link
Copy Markdown
Member

PR-URL: #46109
@RafaelGSS

http: res.setHeaders first implementation
35bdc6c 
PR-URL: nodejs#46109
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
http: backport set.headers 19.x
4002ade

nodejs-github-bot commented Jan 19, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. v19.x labels Jan 19, 2023
RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 20, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 20, 2023

nodejs-github-bot commented Jan 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49096/

This was referenced Jan 21, 2023
Open
Open
Open
Open

nodejs-github-bot commented Jan 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49150/

mcollina approved these changes Jan 24, 2023
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

github-actions Bot mentioned this pull request Jan 25, 2023
Open
12 tasks
marco-ippolito mentioned this pull request Jan 25, 2023
Merged

ruyadorno commented Jan 31, 2023

Copy link
Copy Markdown
Member

This looks like a semver-minor change to me. Does that make sense @marco-ippolito @RafaelGSS ?

ruyadorno added the semver-minor PRs that contain new features and should be released in the next minor version. label Jan 31, 2023
ruyadorno pushed a commit that referenced this pull request Jan 31, 2023
http: res.setHeaders first implementation
1ec6270 
Backport-PR-URL: #46272
PR-URL: #46109
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

ruyadorno commented Jan 31, 2023

Copy link
Copy Markdown
Member

Landed in 1ec6270

ruyadorno closed this Jan 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL