Commit 36227ed
test: fix watch mode test flake
PR-URL: #44739
Backport-PR-URL: #44815
Fixes: #44735
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>1 parent 3abd71a commit 36227ed
1 file changed
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -94,8 +94,10 @@ describe('watch mode', { concurrency: true, timeout: 60_0000 }, () => { | |||
| 94 | 94 | const file = fixtures.path('watch-mode/failing.js'); | |
| 95 | 95 | const { stderr, stdout } = await spawnWithRestarts({ file }); | |
| 96 | 96 | ||
| 97 | + // Use match first to pretty print diff on failure | ||
| 97 | 98 | assert.match(stderr, /Error: fails\r?\n/); | |
| 98 | - assert.strictEqual(stderr.match(/Error: fails\r?\n/g).length, 2); | ||
| 99 | + // Test that failures happen once per restart | ||
| 100 | + assert(stderr.match(/Error: fails\r?\n/g).length >= 2); | ||
| 99 | 101 | assertRestartedCorrectly({ | |
| 100 | 102 | stdout, | |
| 101 | 103 | messages: { completed: `Failed running ${inspect(file)}`, restarted: `Restarting ${inspect(file)}` }, | |
0 commit comments