[v18.x backport] cli: add --watch - #44815
Closed
MoLow wants to merge 4 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This comment was marked as off-topic.
PR-URL: nodejs#44366 Backport-PR-URL: nodejs#44815 Fixes: nodejs#40429 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#44551 Backport-PR-URL: nodejs#44815 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
PR-URL: nodejs#44621 Backport-PR-URL: nodejs#44815 Fixes: nodejs#44655 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: nodejs#44739 Backport-PR-URL: nodejs#44815 Fixes: nodejs#44735 Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MoLow
force-pushed
the
backport-v18-watch-mode
branch
from
fce6dc8 to
f0f5e4f
Compare
September 29, 2022 09:31
Copy link
Copy Markdown
Member
Author
|
CC @nodejs/releasers |
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
17 tasks
RafaelGSS
approved these changes
Sep 30, 2022
This was referenced Oct 1, 2022
danielleadams
approved these changes
Oct 2, 2022
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR backports:
#44366
#44551
#44621
#44739
the change needed was to skip the test combining --import with --watch since --import is blocked from backporting