FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v18.x backport] test_runner: support using `--inspect` with `--test` by MoLow · Pull Request #44813 · nodejs/node · GitHub

/ node Public

[v18.x backport] test_runner: support using --inspect with --test - #44813

Closed
MoLow wants to merge 3 commits into
nodejs:v18.x-stagingfrom
MoLow:backport-test-runner-inspect
ConversationCommits (3)ChecksFiles changed
Closed

[v18.x backport] test_runner: support using --inspect with --test#44813
MoLow wants to merge 3 commits into
nodejs:v18.x-stagingfrom
MoLow:backport-test-runner-inspect

Conversation

MoLow commented Sep 29, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

this backport PR includes
#44520
#44592
#44620

to be merged after / on top of #44815

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v18.x labels Sep 29, 2022
MoLow force-pushed the backport-test-runner-inspect branch from 1cffc6c to 9fbebd2 Compare September 29, 2022 08:54

MoLow commented Sep 29, 2022

Copy link
Copy Markdown
Member Author

CC @nodejs/releasers

MoLow force-pushed the backport-test-runner-inspect branch from 9fbebd2 to c743751 Compare September 29, 2022 09:04
MoLow changed the title [v18.x backport] test_runner: support using --inspect with --test [v18.x backport] test_runner: support using --inspect with --test Sep 29, 2022
MoLow force-pushed the backport-test-runner-inspect branch from c743751 to 37d1e5a Compare September 29, 2022 13:58
MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2022

This comment was marked as outdated.

Sign in to view
github-actions Bot mentioned this pull request Sep 30, 2022
Open
17 tasks

nodejs-github-bot commented Sep 30, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46950/

This was referenced Oct 1, 2022
Open
Open
MoLow added 3 commits October 2, 2022 13:49
test_runner: support using --inspect with --test
faa8f8a 
PR-URL: nodejs#44520
Backport-PR-URL: nodejs#44813
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
cluster: use inspector utils
b48c9a5 
PR-URL: nodejs#44592
Backport-PR-URL: nodejs#44813
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
test: fix test-runner-inspect
a797681 
PR-URL: nodejs#44620
Backport-PR-URL: nodejs#44813
Fixes: nodejs#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow force-pushed the backport-test-runner-inspect branch from 37d1e5a to a797681 Compare October 2, 2022 10:50
MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2022

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented Oct 2, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46994/

github-actions Bot mentioned this pull request Oct 3, 2022
Open
9 tasks

MoLow commented Oct 3, 2022

Copy link
Copy Markdown
Member Author

CC @danielleadams

MoLow added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Oct 3, 2022
danielleadams pushed a commit that referenced this pull request Oct 4, 2022
test_runner: support using --inspect with --test
3c1e9d4 
PR-URL: #44520
Backport-PR-URL: #44813
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Oct 4, 2022
cluster: use inspector utils
7fb9cc7 
PR-URL: #44592
Backport-PR-URL: #44813
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams pushed a commit that referenced this pull request Oct 4, 2022
test: fix test-runner-inspect
56c9c98 
PR-URL: #44620
Backport-PR-URL: #44813
Fixes: #44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

danielleadams commented Oct 4, 2022

Copy link
Copy Markdown
Contributor

Landed in 36227ed...56c9c98

github-actions Bot mentioned this pull request Oct 5, 2022
Open
19 tasks
MoLow deleted the backport-test-runner-inspect branch October 12, 2022 08:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

RafaelGSS RafaelGSS approved these changes
+1 more reviewer
danielleadams danielleadams approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL