test_runner,doc: align documentation with actual stdout/stderr behavior · nodejs/node@3a4a0eb · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 634
• Pull requests 748
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 3a4a0eb

Browse filesBrowse the repository at this point in the historyBrowse files

MoLow

authored and

marco-ippolito

committed

test_runner,doc: align documentation with actual stdout/stderr behavior

PR-URL: #53131 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent 560392d commit 3a4a0eb
Copy full SHA for 3a4a0eb

2 files changed

-16Lines changed: 0 additions & 16 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• doc/api
  • test.md
• lib/internal/test_runner
  • tests_stream.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎doc/api/test.md‎

Copy file name to clipboardExpand all lines: doc/api/test.md

-8Lines changed: 0 additions & 8 deletions

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -2724,11 +2724,7 @@ The corresponding execution ordered event is `'test:dequeue'`.
2724	2724	### Event: `'test:stderr'`
2725	2725
2726	2726	* `data` {Object}
2727		- * `column` {number|undefined} The column number where the test is defined, or
2728		- `undefined` if the test was run through the REPL.
2729	2727	* `file` {string} The path of the test file.
2730		- * `line` {number|undefined} The line number where the test is defined, or
2731		- `undefined` if the test was run through the REPL.
2732	2728	* `message` {string} The message written to `stderr`.
2733	2729
2734	2730	Emitted when a running test writes to `stderr`.
@@ -2739,11 +2735,7 @@ defined.
2739	2735	### Event: `'test:stdout'`
2740	2736
2741	2737	* `data` {Object}
2742		- * `column` {number|undefined} The column number where the test is defined, or
2743		- `undefined` if the test was run through the REPL.
2744	2738	* `file` {string} The path of the test file.
2745		- * `line` {number|undefined} The line number where the test is defined, or
2746		- `undefined` if the test was run through the REPL.
2747	2739	* `message` {string} The message written to `stdout`.
2748	2740
2749	2741	Emitted when a running test writes to `stdout`.

Collapse file

‎lib/internal/test_runner/tests_stream.js‎

Copy file name to clipboardExpand all lines: lib/internal/test_runner/tests_stream.js

-8Lines changed: 0 additions & 8 deletions

Original file line number	Diff line number	Diff line change
@@ -123,14 +123,6 @@ class TestsStream extends Readable {
123	123	});
124	124	}
125	125
126		- stderr(loc, message) {
127		- this[kEmitMessage]('test:stderr', { __proto__: null, message, ...loc });
128		- }
129		-
130		- stdout(loc, message) {
131		- this[kEmitMessage]('test:stdout', { __proto__: null, message, ...loc });
132		- }
133		-
134	126	coverage(nesting, loc, summary) {
135	127	this[kEmitMessage]('test:coverage', {
136	128	__proto__: null,

0 commit comments

Comments

0 (0)